From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2352 invoked by alias); 23 Mar 2018 15:36:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 555 invoked by uid 89); 23 Mar 2018 15:36:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Mar 2018 15:36:06 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w2NFa0Sm021465 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 23 Mar 2018 11:36:04 -0400 Received: by simark.ca (Postfix, from userid 112) id 189011E77E; Fri, 23 Mar 2018 11:36:00 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 87F301E4B2; Fri, 23 Mar 2018 11:35:58 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 23 Mar 2018 15:36:00 -0000 From: Simon Marchi To: Alan Hayward Cc: Simon Marchi , gdb-patches@sourceware.org, nd Subject: Re: [PATCH v4 02/10] Make gdbserver reg_defs a vector of objects In-Reply-To: References: <20180322084429.26250-1-alan.hayward@arm.com> <20180322084429.26250-3-alan.hayward@arm.com> <74733d19-17a0-6a38-73d0-e1201f27d5cd@ericsson.com> Message-ID: <11092a287454586f60c73937a37bc4db@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 23 Mar 2018 15:36:00 +0000 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00444.txt.bz2 On 2018-03-23 10:54, Alan Hayward wrote: >> Please keep the curly braces for the for, as shown here: >> >> https://www.gnu.org/prep/standards/html_node/Syntactic-Conventions.html#index-multiple-variables-in-a-line >> >> Can you put the moving of this function/making it static/removing the >> declaration >> in its own patch? It's pre-approved, with that fixed. >> > > Ok, I’ve pushed this bit as requested: Thanks! > New version updated with all of the above. > Checked this on X86 with make check on target board gdbserver. > (Patch 3/10, and possibly others, will need updating too, but should > be obvious). > > Thanks for the review. > > Alan. I had some problems applying your patch, the tabs were replaced with spaces. You can either fix the settings of your email client, or you can also use git-send-email when sending individual patch updates, like this: git send-email HEAD^ --subject-prefix="PATCH v4.1 02/10" --to --in-reply-to where message-id can be found in the headers of the message you want to reply to (header Message-ID). This allows the message to be correctly threaded. It means the patch will be in a separate email than your response to the reviewer's comments, but I think that's fine. Anyway, this particular one wasn't too difficult to fix up by hand. It LGTM with one nit fixed: > diff --git a/gdb/regformats/regdef.h b/gdb/regformats/regdef.h > index > 262d03c0785f48e83b784b6177c52e2d253a6067..1f7861fd98dd9085c3fe9d7ee4b8396999060265 > 100644 > --- a/gdb/regformats/regdef.h > +++ b/gdb/regformats/regdef.h > @@ -21,6 +21,18 @@ > > struct reg > { > + reg () > + : name (""), > + offset (0), > + size (0) > + {} > + > + reg (const char *_name, int _offset, int _size) The offset value is always 0 initially, so you can remove it and initialize it to 0. I think that this patch can also be pushed on its own, it's a good improvement regardless of the rest of the series. Thanks, Simon