From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2D9273858D28 for ; Tue, 20 Jun 2023 13:49:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D9273858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687268985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H1gDVuW+8TyNlOI7eaPUX8IiLybwvoDyxxPL/PrF1fg=; b=QJklnHfjuZjfbGpsxMZsQuAmJkofVVg8k1dktEOw7Jfdaa3i/PacfOY8VaAMsaMsskw3ne bO6Iz0fQ8FT0NuCSvCXwPmWZ1Nt3q4lDUOxTivf2Tv7lTnJd/6ykB5r7PP+DOZK6R6vt2S Gjm5XIKlyrKRl+G0jB+k8PkFk+/t9jQ= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-Wb4QyA5gPVefOd3GA79N5g-1; Tue, 20 Jun 2023 09:49:44 -0400 X-MC-Unique: Wb4QyA5gPVefOd3GA79N5g-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-763ae45d883so106955285a.3 for ; Tue, 20 Jun 2023 06:49:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687268981; x=1689860981; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H1gDVuW+8TyNlOI7eaPUX8IiLybwvoDyxxPL/PrF1fg=; b=JAx1suflLg4O0rhR9vS6/zNBjhnXHaleOFWWfxUdDW+OkXhK1IrE6v/ITChOGv5dOA NPQHvt8LBpU5IVzHQJzBHYOBJ2b/i61t06c+NKT6Hvv9pO4x3nWXoUk+MM8jvGfFNl17 ik+e6NB9/v7719czhdqS3DpWtlnuwM/khFvNsirq4d+9cgI2NnTacJ3PkDDM1DIYx+Ab LetHKIrCvF7qZir2K+0BoHd5YLTegt/YuFjy3Z+nI729YjAs/bzsfTH84jwCUyfOjLvZ 4Pj/d83+4eMIKesPysgZROuuNZ2edFpbnGKMeI3LtiPi2KSUkZJEwXPwI1Jf0gSBW5M0 sFvQ== X-Gm-Message-State: AC+VfDx3coaC1gkrhsdPr2+59/1Yh5kw0gs7wQPFf57Tql+TvwufJwDA QgcWAEeKmaNiNZwGfJAfWZITPeqvH5rRAZDcOEZUbajlXET6IyUNvV5pmY7kfXbO+7n/vHuyuHx rrzpRFSgcokj6DhVXuPxIVfB+nWixGA== X-Received: by 2002:a05:620a:480c:b0:75b:23a1:424 with SMTP id eb12-20020a05620a480c00b0075b23a10424mr10935950qkb.58.1687268981680; Tue, 20 Jun 2023 06:49:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7UV+0HWon23K05zEeRHOPpeSA+sYfeV03wUp+hi+pUiy4UYM05jvA3K44cOSlylA1umsysWg== X-Received: by 2002:a05:620a:480c:b0:75b:23a1:424 with SMTP id eb12-20020a05620a480c00b0075b23a10424mr10935936qkb.58.1687268981435; Tue, 20 Jun 2023 06:49:41 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id c2-20020ae9e202000000b0075cd3d61715sm1131399qkc.47.2023.06.20.06.49.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jun 2023 06:49:41 -0700 (PDT) Message-ID: <1118c4cc-44c5-a79e-e9f3-dcbf5ca964bd@redhat.com> Date: Tue, 20 Jun 2023 15:49:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/3] gdb/cli: Improve UX when using list with no args To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20230620122910.2459069-1-blarsen@redhat.com> <20230620122910.2459069-3-blarsen@redhat.com> <83ttv25jw0.fsf@gnu.org> <72e04013-9a92-cde5-2312-61e5d5bc4f3d@redhat.com> <83r0q65joo.fsf@gnu.org> From: Bruno Larsen In-Reply-To: <83r0q65joo.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/06/2023 15:48, Eli Zaretskii wrote: >> Date: Tue, 20 Jun 2023 15:46:20 +0200 >> Cc: gdb-patches@sourceware.org >> From: Bruno Larsen >> >> On 20/06/2023 15:43, Eli Zaretskii wrote: >>>> Cc: Bruno Larsen >>>> Date: Tue, 20 Jun 2023 14:29:12 +0200 >>>> From: Bruno Larsen via Gdb-patches >>>> >>>> --- a/gdb/NEWS >>>> +++ b/gdb/NEWS >>>> @@ -78,6 +78,11 @@ >>>> functionality is also available for dprintf when dprintf-style is >>>> 'gdb'. >>>> >>>> +* Using the 'list' command with no arguments in a situation where the >>>> + command would attempt to list past the end of the file, instead of >>>> + erroring out, it will now warn the user that the end of file has been >>>> + reached and the default location. >>> ^^^^^^^^^^^^^^^^^^^^^^^^ >>> What is that "and the default location" part about? It looks >>> misplaced. >>> >> Oops. It is incomplete. It should have been "And the default location >> will be printed", default location being either where the inferior is >> (if it has started already) or around the main function. > If so, I think this also warrants to be mentioned in the manual. Will do! And I'll also add the manual entry to patch 3, as you asked -- Cheers, Bruno