From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 67ED1385483F for ; Fri, 24 Feb 2023 21:44:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67ED1385483F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.255.0.64] (unknown [45.73.127.130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2AB411E0D3; Fri, 24 Feb 2023 16:44:35 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1677275075; bh=clW6ZrMXnAkcNN1NxcnuTRJNKglqjH90eDuNVJFR23U=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Drch0WbblEu2zK4YFTiykdQ4yrjba0yKld+rbzySEPx3pWCEhBJiGK99OkNHnunRP ORSEWo5B6dZgOYtiXMsP5mJhMLfzdsewjAhcPcHGreqlkjcufyyCMYZbWQLzywOHGB LmCWG3tDAymZyMvZtG5Hq082CfxV97Kz6zmz/efk= Message-ID: <1154aa3c-4ef9-80ef-c551-35a9ce8bf294@simark.ca> Date: Fri, 24 Feb 2023 16:44:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 0/2] Write DWARF index cache files in background Content-Language: fr To: Tom Tromey , Tom Tromey via Gdb-patches References: <20221219164558.378363-1-tromey@adacore.com> <87k006j3zz.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87k006j3zz.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/24/23 13:46, Tom Tromey via Gdb-patches wrote: >>>>>> "Tom" == Tom Tromey via Gdb-patches writes: > > Tom> Here's v3 of the patches to write the DWARF index in the background. > Tom> v2 was here: > > Tom> https://sourceware.org/pipermail/gdb-patches/2022-June/189889.html > > Tom> This hides a user-noticeable pause when the feature is enabled. (Note > Tom> that, when the feature is used in batch mode, the pause is still > Tom> seen.) > > Tom> This version of the series fixes a possible race that I found in v2. > Tom> Essentially, the index-writing background job must be started after > Tom> all the finalization tasks have started. There's a comment in the > Tom> code explaining this. > > I'm checking this in now. > > Tom I started seeing this, I guess it's related: FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: at least one file was created FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: expected file is there Simon