From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id B9EB13858D33 for ; Thu, 22 Feb 2024 15:26:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9EB13858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B9EB13858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708615615; cv=none; b=Ue7ES01LTu9KcXqumPIKrgYiemQLbrmEXhS4HGVubN8PX6XNbWcZsEAvXMNUsev6BV2opCitHHwqOBmKxJNcAKPPT49e9RNC5+1GPDbbsSQzniHjkvvFMBj0hemNSq46eVpF4rV6/lgliMnv7Mf5XS6cBSChoymkQO37v0k7Wo4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708615615; c=relaxed/simple; bh=wnqA64J+g6kCEfzu88Goqwx9Bh8NUaBuTje+/BGnT7k=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=GY9KukliqdDopuQA+PR40JDu1GMIV47lvkkQm3fG3CNq4i7pEfGbQoY3uCWAFHhSf6/pfT00V/S+s1wuWPZx3NsLKEYpOgepoRdjA0KoSAYY8D7iL30qMxlvml0iKeJ5QM19SXQZlkk368ddXOvOmuFrNXlpES5wfX8Cuvz3ptM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C4A4E2217B; Thu, 22 Feb 2024 15:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708615612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ZcSB2SG+ZPpQniC1ikoW29WyOxxht2DVvGdb2aFsow=; b=cTGYPwNQpqY4KhfqMkoT6hs/clAnR/SUi8b1dmta2gviCFPzx9G4Gp9x/Q2ZaTEKPhe8lu T+8m8E9oF8LIItBH8uPtBvSKGX3wUPiZ3QU0+D7LlJQPsasYG+lMI6Be3Sua4fK+ZbU1CP JWKyuApSM1A5ZzX249yJglUnMI0uM3Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708615612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ZcSB2SG+ZPpQniC1ikoW29WyOxxht2DVvGdb2aFsow=; b=iBIgE9qpvZ4hiXNJbqtPxTbHDKiJp22RxXt6Dimnotq+85BtDLhUYvPyZWqhalxAUIEFNo ruVa4tSq10cAOsCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708615612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ZcSB2SG+ZPpQniC1ikoW29WyOxxht2DVvGdb2aFsow=; b=cTGYPwNQpqY4KhfqMkoT6hs/clAnR/SUi8b1dmta2gviCFPzx9G4Gp9x/Q2ZaTEKPhe8lu T+8m8E9oF8LIItBH8uPtBvSKGX3wUPiZ3QU0+D7LlJQPsasYG+lMI6Be3Sua4fK+ZbU1CP JWKyuApSM1A5ZzX249yJglUnMI0uM3Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708615612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ZcSB2SG+ZPpQniC1ikoW29WyOxxht2DVvGdb2aFsow=; b=iBIgE9qpvZ4hiXNJbqtPxTbHDKiJp22RxXt6Dimnotq+85BtDLhUYvPyZWqhalxAUIEFNo ruVa4tSq10cAOsCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 535FE13A8C; Thu, 22 Feb 2024 15:26:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XMbaErxn12W6VgAAD6G6ig (envelope-from ); Thu, 22 Feb 2024 15:26:52 +0000 Message-ID: <115c705a-978c-4855-84cc-2b8aa8fda113@suse.de> Date: Thu, 22 Feb 2024 16:26:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tui] Factor out tui_noscroll_window et al Content-Language: en-US To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org References: <20231112150601.25484-1-tdevries@suse.de> <87r0kttwba.fsf@tromey.com> <24af4ea8-5426-4ce4-b1c5-12858b38a952@simark.ca> <549c2044-4ec2-4072-a554-6a66e7ddee1d@suse.de> <668e8103-04e8-4ae1-934a-e64f6fd4dc40@suse.de> <87h6i0zgf3.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87h6i0zgf3.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.58 X-Spamd-Result: default: False [-1.58 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; BAYES_HAM(-0.29)[74.70%]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/22/24 16:07, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> It catches the problem at build time for TUI_STATUS_WIN and > Tom> TUI_CMD_WIN, but not for the other 3. > > Those don't have a problem because they don't use virtual inheritance. > > The problem comes from any class using one of the mixins like: > > struct tui_always_visible_window : public virtual tui_win_info > Hi Tom, Sorry, you're right. I see I confused virtual base with abstract base. Thanks, - Tom