From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic306-20.consmr.mail.ir2.yahoo.com (sonic306-20.consmr.mail.ir2.yahoo.com [77.238.176.206]) by sourceware.org (Postfix) with ESMTPS id 40FE33858C35 for ; Mon, 18 Dec 2023 17:29:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 40FE33858C35 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 40FE33858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.176.206 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702920599; cv=none; b=IyatklNy8PjWDwJ4+Dw+X5+Nh4jJZsrl76xqmR44MdYVBlAiS11EBR2uXUJwmbLV4QDKH0e2WiaIgV/GFDYOIPBRlBiagGhVKF54r+o8Q8403Rf/KfHqWG1h5So98pQ9JK2oO29zjI7ntsFbQS2yVuKPQS1VE+Aou1BpF1lepDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702920599; c=relaxed/simple; bh=x6UctnKEkEQzbMslJOBp1rXrN4tiZclaXlSCvqqQUnA=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=epJs53axL5RNgbR+Lh/aHO+KRA9B9T/aLFctSG4P61SUhAgbHE/L+aChit5txGmeGuZ9fBshBhbK3Ktb/igN8J7UIa045LXGa5ZY0bSkuoIPIIACAUJ8tjVQVuZpArWhUejAx+kT2doT+xz/qDFDFW8WVUvxZGOsdtroQFeXep8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1702920595; bh=x6UctnKEkEQzbMslJOBp1rXrN4tiZclaXlSCvqqQUnA=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=fAVTzNFIhHIjSf6fDVMJ6jFImZf+tJQc1VMIUdIRRTN1M0uaB4wDXe/kBBd8U5VqbxH1Jd7jbAEKKLImCc8uRcv1O1lx3/JqGs6WDS0Hqqo8mHpSczVmTqBhArepGzw7lXawjIW8eLluUo66tZB07QjpGGV2WBBda6BlqMY2Hk9JxmFEXZgkkMSgt13iomqyMCjyS12GmSIj+c6FaWs6ihDYyFN3HI8ZYk/skUVwue1RhHf4d6rb42XHfpHxhHeP4oACP1z6mvDqyrvhLEWs8wBcV3HkKqJyp1VdndVmWnNHTm8N2Y6tIdPH7vO34uIOQfC9H+Qtd0gepzxo5NYHKg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1702920595; bh=6KglqYwjIl+Py0eoo65GP/XgCDE/Bk7PNtyQQBodfCR=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=pAp22kWehyBZdr9+8stucE5yRYdJPSPj0mynNqHDZHpg1Z3vbgVba4vlFRTgpIO9B6BBGkX0db6tRkc3hRTZrRkt9vC+3bV2EKOpffiy9MBOpFiSE989DYRhR5TEiCm1sGg/v8i3B5VcQ7s6ZUlSJ9N8zjMgMdBYDNIaGvTkL4qv7iggdWh8E+veuPKxa5GsnqbRyX/rPTSq++Lrh4xuOpQRKYmzroV6DG9NA7n7hOZzWHaBJDYou2kK3VUA0C4ztg3dlIsslfZSOdVyJXMTadUTi+zsQDiGPziqCI9Iaq80mVpZmrolU6du+R9GWTLF5Jcu7O+UKMQO+1hkwdS3Yg== X-YMail-OSG: D8vMOXoVM1m5DkrA4ahp8FjinDeW9RHGAxP3R_4tWUdQPzdj38afJD0sdtxN3fo yHYs4Hq9nsN.GQ3DmFHkREFkpDLSubVDHOauA8rlCyeluqnos76bcXgveUrmcYWuvj0.Rw2feWfc nW_jVi_82r4d9d61pnnTaTwis9U89_c8zpX5jnf8Oz0NJDVAJMkJC8rvTHv71fRyRsMzq4oap0cH hnXwVi0VxbCHnZsQeJ7U1ploUkkQt2EsFCfYI8077uH12lflEuoYxHMvY8bdezZLPOvs0ug3LjCN CC6XaUB4IFymf.cdVjirAq7JAd6CR1X.t9LxCVwvRLMe8i9_bGfe4Ym.4qVdwrJhuKFKt_UGwbrA EzsRVfmf1a7SjP789gL8g916XDrLXXRpqE5EyZ4YdbXUYcgb1PRaV3t6f_BHLT0E5n6ABNVDVDNJ fYhQHYwJETG2PgzwcPofiv6kXNtEJPDcEquymE7WUtDGj6ztYZBG4m5vWK8dMVYViprQ0ABdmTML Z1J3IZMnUpPdA8hR9mJv8HmiF6RQGa5ZufLaGBohJABlBnI7XSC..StTFDn0lpkngSutmN.Gu3I1 foC054Grr_4OYXnMRcfQ.e2jmqBHPzfPEDemsIqJVUMcVPnS0hOK62GQ1Gr_01s5DnC1E_UuGv6D YGNTo7zKyWifHRFSmQ2u_3VbM4rzJhXjGp80.ii_Ek_9EjeSUtYYAoXzFH7tJ1Ezptc3_q3q0Viw I_zb8tiBqWddubCad.X3NOp5YYapV4M2WdGUyetYvQfo0q4usY82Uh31rZ.Ef0NcYGdHn2VXofZF BYdACTBt1JSRNpr1EiOgADcr2stjiNHcPO_hAiEDexCX.5KRlGAytB3Z_D.cHbkcbtGPDKvr7xVT jJZlNdZ6bgP2slsfbNqUycCYyoYn_W3EWvEU3f28WmOAXugP.dM6Is9Q5i6WP.xy90AynRbq3tGD sXw0CzIqUGKndX5FE3Cv9s4rgsqU9P.niOyhN_pjxscV3xpKx8sv3NlmkQOtMx_NTBPydUCFOWtv bsii4y7SvR6lUl5UucwjaRd7CNOJdzGKXxd6D1cQJPWPxEK2PoH9mM2Bp.2R8hK8RqpokKw8VgcT dd5lpBNNuZqnJ12IrxO48pWsPeWSY7kPcG7AyFXmWkggYmD_C.XhT5jDNIeBSe9xylQ3G9AQQu0T asB6c5.N2SVxU7OkhE6Zao6tYNBXDm4hsEZBRe56nnCS4vz3Xd9RF0eRzGSzpX95CUIpfirWkgbz PqUos0Fae3epYhkxGKY62Vh7AYQ0yDyqPe8HcHlSvn2IlPgi67MiqCwkPmyF_Ynux6TgoB5m7wJh dz5Fho3tMbWvthfjDz6MywulhAg.onJN.jI8g4kj9YT10Dy5tg5UIvMgdjOBXjomEwXuYdeN2ykH T8eDcADOs8V02lnz_glokau3C5144pMK7Y1yCQqWEPQk7uZcE38WhhH1vxGvlIB.Cqxm41tVy50e H.jKYBl2JUXcyCEQVepImWPYUdm2RViylQS44iCbtFgtHrj8cc5XxyiohHfO1x20HMp5w327WIe. yBcaCZYEcbLDjpvG5.YwVMf8v8KOvV8JjxzxfNQoT4FBUfi.CNttHUtQ1IbsS_ZaerdmfE2eE7WE befLcTnUs3MuWoVIhV2XoXzw6ixyXGG2ioynVEIl0RtDjJDIWvy_SnWhXL.EkdVhLkWoWjEEu9Pk b3wxbi_cWiUjHJc81JI9HGy5C4E_yyS3IRQfWioYu.Yt2_bjGZeP9ICtEr806pRmEwBW89pOq4hj 327nhpRgil5uXCVBp8DADfejGMSkRi2IEp6SxHunr4Bf8lhqN9puimzX8g88xSlZDsK59nt4aRkL DCNVKxGnIq.Sgck_AuVlKfFrVsKgJN3kyu1yphcRipUXlTTIHuCa_lP.MYa1sYdK185FAp.QMbUm G1So9Xf4uoZvUALqD6r2tUbTsVqTYCRL0ChsM3hmg8mQpgSPqUxYwBClngtDhhu9isWIsGbyk20e 45J0zXxCpYPZCUUy5ZfZnAKMn.lmzGYJPaDVSVkt4blhM1MK9TwzcF6MkRkhSo1z7e1PVzjh8FVB mbWjjImf8WptUAwnjNdMnz8EXQn5X7Wm15lsQ9.SEe6il4d501vHn89eLvr27D2DHxT8zLqRMgrq euUkvMtK10m8Us6JnUfyvN6xzYzIqCiCBPsDZ16SCDBg7LFf4TioVsFgVbWturIDne4.tVmH4S3w k_R4gXYhDjS534Sqj0jdwqnlkViE3rtMZnf7RluI- X-Sonic-MF: X-Sonic-ID: ed87a6ed-d2f1-4ea9-b175-527db96616e9 Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ir2.yahoo.com with HTTP; Mon, 18 Dec 2023 17:29:55 +0000 Date: Mon, 18 Dec 2023 17:29:54 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" , Tom Tromey Message-ID: <1177177349.4456564.1702920594108@mail.yahoo.com> In-Reply-To: <20231217-tui-regs-cleanup-v1-5-67bd0ea1e8be@tromey.com> References: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> <20231217-tui-regs-cleanup-v1-5-67bd0ea1e8be@tromey.com> Subject: Re: [PATCH 05/14] Remove tui_register_info::visible MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21952 YMailNorrin X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am Sonntag, 17. Dezember 2023, 20:51:14 MEZ hat Tom Tromey Folgendes geschrieben: > tui_register_info::visible is redundant with the fact that y=3D=3D0 means > that the register is not visible -- and some spots already check the > latter.=C2=A0 This patch removes this member in favor of having a single > indication of the register's visibility.=C2=A0 This change makes it clear > that delete_data_content_windows is not needed, so this is removed as > well. > --- > gdb/tui/tui-regs.c | 15 +-------------- > gdb/tui/tui-regs.h |=C2=A0 1 - > 2 files changed, 1 insertion(+), 15 deletions(-) > > diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c > index f87d1ff8721..9108e460d6f 100644 > --- a/gdb/tui/tui-regs.c > +++ b/gdb/tui/tui-regs.c > @@ -269,7 +269,6 @@ tui_data_window::display_registers_from (int start_el= ement_no) >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Create the window if necessary.=C2= =A0 */ >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 m_regs_content[i].x =3D box_width () = + (m_item_width * j); >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 m_regs_content[i].y =3D cur_y; > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 m_regs_content[i].visible =3D true; >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 m_regs_content[i].rerender (handle.ge= t (), m_item_width); >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 i++;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 /* Next register.=C2=A0 */ >=C2=A0=C2=A0=C2=A0=C2=A0 } > @@ -347,23 +346,13 @@ tui_data_window::first_data_item_displayed () > { >=C2=A0=C2=A0 for (int i =3D 0; i < m_regs_content.size (); i++) >=C2=A0=C2=A0=C2=A0=C2=A0 { > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (m_regs_content[i].visible) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (m_regs_content[i].y > 0) >=C2=A0=C2=A0=C2=A0=C2=A0 return i; >=C2=A0=C2=A0=C2=A0=C2=A0 } > >=C2=A0=C2=A0 return -1; > } > > -/* See tui-regs.h.=C2=A0 */ > - > -void > -tui_data_window::delete_data_content_windows () > -{ > -=C2=A0 for (auto &win : m_regs_content) > -=C2=A0=C2=A0=C2=A0 win.visible =3D false; > > -} > - > - > void > > tui_data_window::erase_data_content (const char *prompt) > { > @@ -401,7 +390,6 @@ tui_data_window::rerender (bool toplevel) >=C2=A0=C2=A0 else >=C2=A0=C2=A0=C2=A0=C2=A0 { >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 erase_data_content (NULL); > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 delete_data_content_windows (); >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 display_registers_from (0); >=C2=A0=C2=A0=C2=A0=C2=A0 } > } > @@ -426,7 +414,6 @@ tui_data_window::do_scroll_vertical (int num_to_scrol= l) >=C2=A0=C2=A0=C2=A0=C2=A0 { >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 first_line +=3D num_to_scroll; >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 erase_data_content (NULL); > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 delete_data_content_windows (); >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 display_registers_from_line (first_li= ne); >=C2=A0=C2=A0=C2=A0=C2=A0 } > } > diff --git a/gdb/tui/tui-regs.h b/gdb/tui/tui-regs.h > index 1a9f30fa270..701b8707947 100644 > --- a/gdb/tui/tui-regs.h > +++ b/gdb/tui/tui-regs.h > @@ -50,7 +50,6 @@ struct tui_register_info >=C2=A0=C2=A0 /* The register number.=C2=A0 */ >=C2=A0=C2=A0 int regno; >=C2=A0=C2=A0 bool highlight =3D false; > -=C2=A0 bool visible =3D false; >=C2=A0=C2=A0 std::string content; > }; > > > -- > 2.43.0 I think you missed removing tui_data_window::delete_data_content_windows from tui-regs.h. Regards Hannes