From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCHv3 1/2] gdb/amd64: Ignore zero sized fields when calling functions
Date: Sat, 03 Mar 2018 06:29:00 -0000 [thread overview]
Message-ID: <11cad30a-02f3-f107-f8ac-4166f0312f1b@simark.ca> (raw)
In-Reply-To: <a99f02ac2ff15d7c4ffffda9fc7125267a53f6fd.1520021226.git.andrew.burgess@embecosm.com>
On 2018-03-02 03:09 PM, Andrew Burgess wrote:
> In some cases passing an argument to a function on amd64, or attempting
> to fetch the return value, can trigger an assertion failure within GDB.
> An example of a type that would trigger such an error is:
>
> struct foo_t
> {
> long double a;
> struct {
> struct {
> /* Empty. */
> } es1;
> } s1;
> };
>
> GCC does permit empty structures, so we should probably support this.
>
> The test that exposes this bug is in the next commit along with the
> RiscV support.
Good job on the test :). This patch LGTM.
Simon
next prev parent reply other threads:[~2018-03-03 6:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 19:15 [PATCH] gdb: Initial baremetal riscv support Andrew Burgess
2018-02-13 19:49 ` Eli Zaretskii
2018-02-19 20:01 ` Simon Marchi
2018-02-27 1:09 ` [PATCHv2] " Andrew Burgess
2018-02-27 3:33 ` Simon Marchi
2018-03-02 20:09 ` [PATCHv3 0/2] Initial RiscV Support Andrew Burgess
2018-03-02 20:10 ` [PATCHv3 2/2] gdb: Initial baremetal riscv support Andrew Burgess
2018-03-03 6:27 ` Simon Marchi
2018-03-05 10:46 ` [PATCHv4 " Andrew Burgess
2018-03-05 22:35 ` Simon Marchi
2018-03-06 11:06 ` Yao Qi
2018-03-06 11:35 ` Yao Qi
2018-03-03 7:40 ` [PATCHv3 " Eli Zaretskii
2018-03-02 20:10 ` [PATCHv3 1/2] gdb/amd64: Ignore zero sized fields when calling functions Andrew Burgess
2018-03-03 6:29 ` Simon Marchi [this message]
2018-02-27 3:37 ` [PATCHv2] gdb: Initial baremetal riscv support Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11cad30a-02f3-f107-f8ac-4166f0312f1b@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).