From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 65BE9385480B for ; Fri, 18 Dec 2020 22:25:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 65BE9385480B Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0BIMOY8T019738 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Dec 2020 17:24:39 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0BIMOY8T019738 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 952E61E552; Fri, 18 Dec 2020 17:24:34 -0500 (EST) Subject: Re: [PATCH v2] inferior without argument prints detail of current inferior To: Lancelot SIX , gdb-patches@sourceware.org References: <20201218220440.12127-1-lsix@lancelotsix.com> From: Simon Marchi Message-ID: <11db31d0-2dc1-2f87-7a8f-4ce1e1026874@polymtl.ca> Date: Fri, 18 Dec 2020 17:24:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201218220440.12127-1-lsix@lancelotsix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 18 Dec 2020 22:24:34 +0000 X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Dec 2020 22:25:53 -0000 On 2020-12-18 5:04 p.m., Lancelot SIX via Gdb-patches wrote: > This patch makes the inferior command display information about the > current inferior when called with no argument. This behavior is similar > to the one of the thread command. > > This contribution is inspired by an item in > https://sourceware.org/gdb/wiki/ProjectIdeas > > Before patch: > > (gdb) info inferior > Num Description Connection Executable > * 1 process 19221 1 (native) /home/lsix/tmp/a.out > 2 process 19239 1 (native) /home/lsix/tmp/a.out > (gdb) inferior 2 > [Switching to inferior 2 [process 19239] (/home/lsix/tmp/a.out)] > [Switching to thread 2.1 (process 19239)] > #0 0x0000000000401146 in main () > (gdb) inferior > Argument required (expression to compute). > > After patch: > > (gdb) info inferior > Num Description Connection Executable > * 1 process 18699 1 (native) /home/lsix/tmp/a.out > 2 process 18705 1 (native) /home/lsix/tmp/a.out > (gdb) inferior 2 > [Switching to inferior 2 [process 18705] (/home/lsix/tmp/a.out)] > [Switching to thread 2.1 (process 18705)] > #0 0x0000000000401146 in main () > (gdb) inferior > [Current inferior is 2 [process 18705] (/home/lsix/tmp/a.out)] > > My copyright assignment request is currently in progress. > > gdb/doc/ChangeLog: > > 2020-12-16 Lancelot SIX > > * gdb.texinfo: Document the inferior command when used without > argument For the ChangeLog entity in the entry here, find the nearest @node that contains the change. > > gdb/ChangeLog: > > 2020-12-16 Lancelot SIX > > * inferior.c (inferior_command): When no argument is given to the > inferior command, display info about the currently selected > inferior. > > gdb/testsuite/ChangeLog: > > 2020-12-16 Lancelot SIX > > * gdb.base/inferior-noarg.c: New test. > * gdb.base/inferior-noarg.exp: New test. > --- > gdb/doc/gdb.texinfo | 16 +++++++ > gdb/inferior.c | 58 +++++++++++++++-------- > gdb/testsuite/gdb.base/inferior-noarg.c | 22 +++++++++ > gdb/testsuite/gdb.base/inferior-noarg.exp | 36 ++++++++++++++ > 4 files changed, 111 insertions(+), 21 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/inferior-noarg.c > create mode 100644 gdb/testsuite/gdb.base/inferior-noarg.exp > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 5b6ac8549b..c9ee0b87f2 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -3202,6 +3202,22 @@ For example, > 2 process 2307 2 (extended-remote host:10000) hello > @end smallexample > > +To get informations about the current inferior, use @code{inferior}: > + > +@table @code > +@kindex inferior > +@item inferior > +Shows information about the current inferior. > + > +For example, > +@end table > +@c end table here to get a little more width for example > + > +@smallexample > +(@value{GDBP}) inferior > +[Current inferior is 1 [process 3401] (helloworld)] > +@end smallexample > + > To find out what open target connections exist at any moment, use > @w{@code{info connections}}: The documentation bits will have to be reviewed by Eli. > diff --git a/gdb/testsuite/gdb.base/inferior-noarg.c b/gdb/testsuite/gdb.base/inferior-noarg.c > new file mode 100644 > index 0000000000..9d7b2f1a4c > --- /dev/null > +++ b/gdb/testsuite/gdb.base/inferior-noarg.c > @@ -0,0 +1,22 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2020 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +int > +main (void) > +{ > + return 0; > +} I kinda recall that we had one dummy C file that we re-used instead of creating more trivial ones like that. But I can't find it, so this LGTM unless someone finds it. Otherwise, let's patiently wait for your copyright assignment. Simon