From: John Baldwin <jhb@FreeBSD.org>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb/make-target-delegates.py: don't handle "void" in parse_argtypes
Date: Tue, 16 Apr 2024 09:06:51 -0700 [thread overview]
Message-ID: <11e63b74-829d-49e1-bcd2-a784ce2afda0@FreeBSD.org> (raw)
In-Reply-To: <20240416155229.1543806-1-simon.marchi@polymtl.ca>
On 4/16/24 8:52 AM, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@efficios.com>
>
> I suppose this was needed when we had `void` in declarations of methods
> with no parameters. If so, we no longer need it.
>
> Change-Id: I0a2b398408aa129634e2d73097a038f7f80db4b4
> ---
> gdb/make-target-delegates.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/make-target-delegates.py b/gdb/make-target-delegates.py
> index 4d18d2802ced..1893fc63ca84 100755
> --- a/gdb/make-target-delegates.py
> +++ b/gdb/make-target-delegates.py
> @@ -149,8 +149,9 @@ def parse_argtypes(typestr: str):
> typestr = re.sub(r"^\((.*)\)$", r"\1", typestr)
> result: list[str] = []
> for item in re.split(r",\s*", typestr):
> - if item == "void" or item == "":
> + if item == "":
> continue
> +
> m = ARGTYPES.match(item)
> if m:
> if m.group("E"):
>
> base-commit: 3f6a060c7543332d0cb4377fc318e2db01ea1d3c
Seems ok to me. I assume it doesn't result in any differences in the generated
code today?
Approved-By: John Baldwin <jhb@FreeBSD.org>
--
John Baldwin
next prev parent reply other threads:[~2024-04-16 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 15:52 Simon Marchi
2024-04-16 16:06 ` John Baldwin [this message]
2024-04-16 16:14 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11e63b74-829d-49e1-bcd2-a784ce2afda0@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).