From: Simon Marchi <simon.marchi@polymtl.ca>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: add field::name / field::set_name
Date: Thu, 30 Sep 2021 22:13:24 -0400 [thread overview]
Message-ID: <12383f91-baca-1c1e-39b6-f0a3037eef8b@polymtl.ca> (raw)
In-Reply-To: <20210830154949.195237-1-simon.marchi@efficios.com>
On 2021-08-30 11:49, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> Add the `name` and `set_name` methods on `struct field`, in order to
> remove `FIELD_NAME` and `TYPE_FIELD_NAME` macros. In this patch, the
> macros are changed to use `field::name`, so all the call sites that are
> used to set the field's name are changed to use `field::set_name`.
> The next patch will remove the macros completely.
>
> Note that because of the name clash between the existing field named
> `name` and the new method, I renamed the field `m_name`. It is not
> private per-se, because we can't make `struct field` a non-POD yet, but
> it should be considered private anyway (not accessed outside `struct
> field`).
>
> Change-Id: If16ddbca4e0c39d0ff9da420bb5cdebe5b9b0896
I pushed these two patches.
Simon
prev parent reply other threads:[~2021-10-01 2:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 15:49 Simon Marchi
2021-08-30 15:49 ` [PATCH 2/2] gdb: remove TYPE_FIELD_NAME and FIELD_NAME macros Simon Marchi
2021-10-01 2:13 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12383f91-baca-1c1e-39b6-f0a3037eef8b@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).