From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1F3E63849ACF for ; Fri, 19 Apr 2024 19:07:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F3E63849ACF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F3E63849ACF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713553650; cv=none; b=ep0JfvY1Z63wffB5guZ97034zEx9MK7wIMscTZqQlek8EotN/0QilUhYi2e4BO9S5ANjH5NUN2Q7W2BfD1UlO2dcCKuE1OxD+o0eNwq3YYyWyX0bzIp1WGxVCM2iNgT/YA3Bn8xSCZNEYpTuPSjWuL/iry+vu2JLf0VnYSTut5M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713553650; c=relaxed/simple; bh=36KTE0i9NR2146EHNSOQsr5wKK4VO2HcFvf+ZH5RFww=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=v6uP4wikUuAj0PkdAMB2smntngZXj1iIxvTd3BpdEH24rcIxAEHJdF/YMBMtBTDbR21t9ijWZVR+RfX5035xBdTetqSTUPVmmb7Qer8FXlxIMmM+XmJYev8PnHGufW7jTzZmjrP6P0g/mp6DalT1zOAxnp3rRdHtQi1c4gD0mDc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 43JJ7Lps006824 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Apr 2024 15:07:25 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 43JJ7Lps006824 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1713553646; bh=T3OpMBno+9ohHubKfygNk/V5pLrt8AVCYW861Ufk6bI=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=PS0vYCNcS7ohCTOtK0JFLbMzne0Lvs0Gm1n3dY9KYkxENFEgTcypENwS0KGsG9HJd aK8WAfiKahil2B3aPPwBSar3Y4HK5fAZAIAOSpKnrvjFxXnuIVntv1XpZjoxLyDuod 4FlmBK+0O5KwQ9xmT+pBhFFWHoDXP1tRt7XHvoWU= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 91B071E030; Fri, 19 Apr 2024 15:07:20 -0400 (EDT) Message-ID: <124aeea2-380f-454f-b3bb-66cb51887428@polymtl.ca> Date: Fri, 19 Apr 2024 15:07:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] gdb: add includes in target-debug.h To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi References: <20240417205426.2030615-1-simon.marchi@polymtl.ca> <87wmotuq8s.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87wmotuq8s.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 19 Apr 2024 19:07:21 +0000 X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-19 15:06, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> From: Simon Marchi > Simon> Editing target-debug.h with clangd shows a bunch of errors. Add some > Simon> includes to fix that (make target-debug.h include what it uses). > > I think generally this kind of thing is obvious, unless adding the > include is somehow problematic or weird. Ok, thanks, I'll keep that in mind for the following times (I think there will be more of these). Simon