* [PATCH] sim: convert old style function definitions
@ 2010-03-29 22:25 Mike Frysinger
2010-03-29 22:37 ` [PATCH v2] " Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2010-03-29 22:25 UTC (permalink / raw)
To: gdb-patches
Some more old style function definitions conversions to fix GCC warnings:
sim-options.c: In function 'dup_arg_p':
sim-options.c:480: warning: old-style function definition
sim-options.c: In function 'sim_parse_args':
sim-options.c:512: warning: old-style function definition
sim-options.c: In function 'sim_print_help':
sim-options.c:799: warning: old-style function definition
sim-trace.c: In function 'set_trace_option_mask':
sim-trace.c:155: warning: old-style function definition
sim-trace.c: In function 'set_trace_option':
sim-trace.c:234: warning: old-style function definition
sim-utils.c: In function 'sim_analyze_program':
sim-utils.c:227: warning: old-style function definition
sim-utils.c: In function 'sim_elapsed_time_get':
sim-utils.c:301: warning: old-style function definition
sim-utils.c: In function 'sim_elapsed_time_since':
sim-utils.c:322: warning: old-style function definition
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
2010-03-29 Mike Frysinger <vapier@gentoo.org>
* sim-options.c (dup_arg_p): Convert old-style function definition.
(sim_parse_args): Likewise.
(sim_print_help): Likewise.
* sim-trace.c (set_trace_option_mask): Likewise.
(set_trace_option): Likewise.
* sim-utils.c (sim_analyze_program): Likewise.
(sim_elapsed_time_get): Likewise.
(sim_elapsed_time_since): Likewise.
sim/common/sim-options.c | 8 ++------
sim/common/sim-trace.c | 12 ++----------
sim/common/sim-utils.c | 10 +++-------
3 files changed, 7 insertions(+), 23 deletions(-)
diff --git a/sim/common/sim-options.c b/sim/common/sim-options.c
index 3369ca2..670051d 100644
--- a/sim/common/sim-options.c
+++ b/sim/common/sim-options.c
@@ -520,9 +520,7 @@ dup_arg_p (arg)
/* Called by sim_open to parse the arguments. */
SIM_RC
-sim_parse_args (sd, argv)
- SIM_DESC sd;
- char **argv;
+sim_parse_args (SIM_DESC sd, char **argv)
{
int c, i, argc, num_opts;
char *p, *short_options;
@@ -807,9 +805,7 @@ print_help (SIM_DESC sd, sim_cpu *cpu, const struct option_list *ol, int is_comm
/* Print help messages for the options. */
void
-sim_print_help (sd, is_command)
- SIM_DESC sd;
- int is_command;
+sim_print_help (SIM_DESC sd, int is_command)
{
if (STATE_OPEN_KIND (sd) == SIM_OPEN_STANDALONE)
sim_io_printf (sd, "Usage: %s [options] program [program args]\n",
diff --git a/sim/common/sim-trace.c b/sim/common/sim-trace.c
index 2397fe8..478cbfa 100644
--- a/sim/common/sim-trace.c
+++ b/sim/common/sim-trace.c
@@ -147,11 +147,7 @@ static const OPTION trace_options[] =
/* Set/reset the trace options indicated in MASK. */
static SIM_RC
-set_trace_option_mask (sd, name, mask, arg)
- SIM_DESC sd;
- const char *name;
- int mask;
- const char *arg;
+set_trace_option_mask (SIM_DESC sd, const char *name, int mask, const char *arg)
{
int trace_nr;
int cpu_nr;
@@ -226,11 +222,7 @@ set_trace_option_mask (sd, name, mask, arg)
/* Set one trace option based on its IDX value. */
static SIM_RC
-set_trace_option (sd, name, idx, arg)
- SIM_DESC sd;
- const char *name;
- int idx;
- const char *arg;
+set_trace_option (SIM_DESC sd, const char *name, int idx, const char *arg)
{
return set_trace_option_mask (sd, name, 1 << idx, arg);
}
diff --git a/sim/common/sim-utils.c b/sim/common/sim-utils.c
index 033be5c..fb84eb3 100644
--- a/sim/common/sim-utils.c
+++ b/sim/common/sim-utils.c
@@ -218,10 +218,7 @@ sim_add_commas (char *buf, int sizeof_buf, unsigned long value)
bfd open. */
SIM_RC
-sim_analyze_program (sd, prog_name, prog_bfd)
- SIM_DESC sd;
- char *prog_name;
- bfd *prog_bfd;
+sim_analyze_program (SIM_DESC sd, char *prog_name, bfd *prog_bfd)
{
asection *s;
SIM_ASSERT (STATE_MAGIC (sd) == SIM_MAGIC_NUMBER);
@@ -295,7 +292,7 @@ sim_analyze_program (sd, prog_name, prog_bfd)
/* Called before sim_elapsed_time_since to get a reference point. */
SIM_ELAPSED_TIME
-sim_elapsed_time_get ()
+sim_elapsed_time_get (void)
{
#ifdef HAVE_GETRUSAGE
struct rusage mytime;
@@ -315,8 +312,7 @@ sim_elapsed_time_get ()
The actual time may be cpu usage (preferred) or wall clock. */
unsigned long
-sim_elapsed_time_since (start)
- SIM_ELAPSED_TIME start;
+sim_elapsed_time_since (SIM_ELAPSED_TIME start)
{
#ifdef HAVE_GETRUSAGE
return sim_elapsed_time_get () - start;
--
1.7.0.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] sim: convert old style function definitions
2010-03-29 22:25 [PATCH] sim: convert old style function definitions Mike Frysinger
@ 2010-03-29 22:37 ` Mike Frysinger
2010-03-30 16:39 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2010-03-29 22:37 UTC (permalink / raw)
To: gdb-patches
Some more old style function definitions conversions to fix GCC warnings:
sim-options.c: In function 'dup_arg_p':
sim-options.c:480: warning: old-style function definition
sim-options.c: In function 'sim_parse_args':
sim-options.c:512: warning: old-style function definition
sim-options.c: In function 'sim_print_help':
sim-options.c:799: warning: old-style function definition
sim-trace.c: In function 'set_trace_option_mask':
sim-trace.c:155: warning: old-style function definition
sim-trace.c: In function 'set_trace_option':
sim-trace.c:234: warning: old-style function definition
sim-utils.c: In function 'sim_analyze_program':
sim-utils.c:227: warning: old-style function definition
sim-utils.c: In function 'sim_elapsed_time_get':
sim-utils.c:301: warning: old-style function definition
sim-utils.c: In function 'sim_elapsed_time_since':
sim-utils.c:322: warning: old-style function definition
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
v2
- err, forgot to actually include dup_arg_p changes.
2010-03-29 Mike Frysinger <vapier@gentoo.org>
* sim-options.c (dup_arg_p): Convert old-style function definition.
(sim_parse_args): Likewise.
(sim_print_help): Likewise.
* sim-trace.c (set_trace_option_mask): Likewise.
(set_trace_option): Likewise.
* sim-utils.c (sim_analyze_program): Likewise.
(sim_elapsed_time_get): Likewise.
(sim_elapsed_time_since): Likewise.
sim/common/sim-options.c | 11 +++--------
sim/common/sim-trace.c | 12 ++----------
sim/common/sim-utils.c | 10 +++-------
3 files changed, 8 insertions(+), 25 deletions(-)
diff --git a/sim/common/sim-options.c b/sim/common/sim-options.c
index 3369ca2..571b292 100644
--- a/sim/common/sim-options.c
+++ b/sim/common/sim-options.c
@@ -489,8 +489,7 @@ standard_install (SIM_DESC sd)
#define ARG_HASH(a) ((256 * (unsigned char) a[0] + (unsigned char) a[1]) % ARG_HASH_SIZE)
static int
-dup_arg_p (arg)
- char *arg;
+dup_arg_p (char *arg)
{
int hash;
static char **arg_table = NULL;
@@ -520,9 +519,7 @@ dup_arg_p (arg)
/* Called by sim_open to parse the arguments. */
SIM_RC
-sim_parse_args (sd, argv)
- SIM_DESC sd;
- char **argv;
+sim_parse_args (SIM_DESC sd, char **argv)
{
int c, i, argc, num_opts;
char *p, *short_options;
@@ -807,9 +804,7 @@ print_help (SIM_DESC sd, sim_cpu *cpu, const struct option_list *ol, int is_comm
/* Print help messages for the options. */
void
-sim_print_help (sd, is_command)
- SIM_DESC sd;
- int is_command;
+sim_print_help (SIM_DESC sd, int is_command)
{
if (STATE_OPEN_KIND (sd) == SIM_OPEN_STANDALONE)
sim_io_printf (sd, "Usage: %s [options] program [program args]\n",
diff --git a/sim/common/sim-trace.c b/sim/common/sim-trace.c
index 2397fe8..478cbfa 100644
--- a/sim/common/sim-trace.c
+++ b/sim/common/sim-trace.c
@@ -147,11 +147,7 @@ static const OPTION trace_options[] =
/* Set/reset the trace options indicated in MASK. */
static SIM_RC
-set_trace_option_mask (sd, name, mask, arg)
- SIM_DESC sd;
- const char *name;
- int mask;
- const char *arg;
+set_trace_option_mask (SIM_DESC sd, const char *name, int mask, const char *arg)
{
int trace_nr;
int cpu_nr;
@@ -226,11 +222,7 @@ set_trace_option_mask (sd, name, mask, arg)
/* Set one trace option based on its IDX value. */
static SIM_RC
-set_trace_option (sd, name, idx, arg)
- SIM_DESC sd;
- const char *name;
- int idx;
- const char *arg;
+set_trace_option (SIM_DESC sd, const char *name, int idx, const char *arg)
{
return set_trace_option_mask (sd, name, 1 << idx, arg);
}
diff --git a/sim/common/sim-utils.c b/sim/common/sim-utils.c
index 033be5c..fb84eb3 100644
--- a/sim/common/sim-utils.c
+++ b/sim/common/sim-utils.c
@@ -218,10 +218,7 @@ sim_add_commas (char *buf, int sizeof_buf, unsigned long value)
bfd open. */
SIM_RC
-sim_analyze_program (sd, prog_name, prog_bfd)
- SIM_DESC sd;
- char *prog_name;
- bfd *prog_bfd;
+sim_analyze_program (SIM_DESC sd, char *prog_name, bfd *prog_bfd)
{
asection *s;
SIM_ASSERT (STATE_MAGIC (sd) == SIM_MAGIC_NUMBER);
@@ -295,7 +292,7 @@ sim_analyze_program (sd, prog_name, prog_bfd)
/* Called before sim_elapsed_time_since to get a reference point. */
SIM_ELAPSED_TIME
-sim_elapsed_time_get ()
+sim_elapsed_time_get (void)
{
#ifdef HAVE_GETRUSAGE
struct rusage mytime;
@@ -315,8 +312,7 @@ sim_elapsed_time_get ()
The actual time may be cpu usage (preferred) or wall clock. */
unsigned long
-sim_elapsed_time_since (start)
- SIM_ELAPSED_TIME start;
+sim_elapsed_time_since (SIM_ELAPSED_TIME start)
{
#ifdef HAVE_GETRUSAGE
return sim_elapsed_time_get () - start;
--
1.7.0.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] sim: convert old style function definitions
2010-03-29 22:37 ` [PATCH v2] " Mike Frysinger
@ 2010-03-30 16:39 ` Tom Tromey
0 siblings, 0 replies; 3+ messages in thread
From: Tom Tromey @ 2010-03-30 16:39 UTC (permalink / raw)
To: Mike Frysinger; +Cc: gdb-patches
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> 2010-03-29 Mike Frysinger <vapier@gentoo.org>
Mike> * sim-options.c (dup_arg_p): Convert old-style function definition.
Mike> (sim_parse_args): Likewise.
Mike> (sim_print_help): Likewise.
Mike> * sim-trace.c (set_trace_option_mask): Likewise.
Mike> (set_trace_option): Likewise.
Mike> * sim-utils.c (sim_analyze_program): Likewise.
Mike> (sim_elapsed_time_get): Likewise.
Mike> (sim_elapsed_time_since): Likewise.
This is ok, thanks.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-30 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-29 22:25 [PATCH] sim: convert old style function definitions Mike Frysinger
2010-03-29 22:37 ` [PATCH v2] " Mike Frysinger
2010-03-30 16:39 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).