Re: [patch] Add support for ARMv7M devices.

[Matthew Gretton-Dann <matthew.gretton-dann@arm.com>]

Hi,

On Wed, 2010-06-09 at 07:03 -0700, Kazu Hirata wrote:
> Hi,
> 
> Attached is a patch to add support for ARMv7M devices.
> 
> The patch is bigger than it really is due to the signature change to
> arm_pc_is_thumb.
> 
> Index: gdb/arm-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> retrieving revision 1.304
> @@ -6431,7 +6445,14 @@ arm_gdbarch_init (struct gdbarch_info in
>        feature = tdesc_find_feature (info.target_desc,
>  				    "org.gnu.gdb.arm.core");
>        if (feature == NULL)
> -	return NULL;
> +	{
> +	  feature = tdesc_find_feature (info.target_desc,
> +					"org.gnu.gdb.arm.core-v7m");
> +	  if (feature == NULL)
> +	    return NULL;
> +	  else
> +	    is_m = 1;
> +	}
>  
>        tdesc_data = tdesc_data_alloc ();
>  

I don't see a definition of the "org.gnu.gdb.arm.core-v7m" feature
anywhere in the sources.  Can you please add the appropriate XML and
derived C files to the patch - or am I missing something?

Also, I think the core-v7m feature should be an extension/synonym for a
core-v6m feature rather than a new feature in its own right (see Richard
Earnshaw's comments).

Thanks,

Matt


-- 
Matthew Gretton-Dann
Principal Engineer - PDSW Tools
ARM Ltd