From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4039 invoked by alias); 10 Jun 2010 08:56:42 -0000 Received: (qmail 4023 invoked by uid 22791); 10 Jun 2010 08:56:40 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (217.140.96.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Jun 2010 08:56:27 +0000 Received: from cam-owa2.Emea.Arm.com (cam-owa2.emea.arm.com [10.1.105.18]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id o5A8uKeI012589; Thu, 10 Jun 2010 09:56:20 +0100 (BST) Received: from [10.1.77.63] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 10 Jun 2010 09:56:20 +0100 Subject: Re: [patch] Add support for ARMv7M devices. From: Matthew Gretton-Dann To: Kazu Hirata Cc: gdb-patches@sourceware.org, dan@codesourcery.com In-Reply-To: <20100609140312.291855664EF@henry1.codesourcery.com> References: <20100609140312.291855664EF@henry1.codesourcery.com> Content-Type: text/plain; charset="ISO-8859-1" Date: Thu, 10 Jun 2010 08:56:00 -0000 Message-ID: <1276160179.3283.5.camel@e102319-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00241.txt.bz2 Hi, On Wed, 2010-06-09 at 07:03 -0700, Kazu Hirata wrote: > Hi, > > Attached is a patch to add support for ARMv7M devices. > > The patch is bigger than it really is due to the signature change to > arm_pc_is_thumb. > > Index: gdb/arm-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/arm-tdep.c,v > retrieving revision 1.304 > @@ -6431,7 +6445,14 @@ arm_gdbarch_init (struct gdbarch_info in > feature = tdesc_find_feature (info.target_desc, > "org.gnu.gdb.arm.core"); > if (feature == NULL) > - return NULL; > + { > + feature = tdesc_find_feature (info.target_desc, > + "org.gnu.gdb.arm.core-v7m"); > + if (feature == NULL) > + return NULL; > + else > + is_m = 1; > + } > > tdesc_data = tdesc_data_alloc (); > I don't see a definition of the "org.gnu.gdb.arm.core-v7m" feature anywhere in the sources. Can you please add the appropriate XML and derived C files to the patch - or am I missing something? Also, I think the core-v7m feature should be an extension/synonym for a core-v6m feature rather than a new feature in its own right (see Richard Earnshaw's comments). Thanks, Matt -- Matthew Gretton-Dann Principal Engineer - PDSW Tools ARM Ltd