public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: [commit] Build memmem with -Wno-error.
Date: Tue, 31 Aug 2010 19:08:00 -0000	[thread overview]
Message-ID: <1283281706-30409-1-git-send-email-brobecker@adacore.com> (raw)

See comment explaining why we need to do this. (and also discussed
on IRC with Pedro).

gdb/gdbserver/ChangeLog:

        * Makefile.in (memmem.o): Build with -Wno-error.

Tested on x86_64-linux. Since it was verbally approved by Pedro,
I will commit this sometime today.

---
 gdb/gdbserver/Makefile.in |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in
index e397bd7..ffec46f 100644
--- a/gdb/gdbserver/Makefile.in
+++ b/gdb/gdbserver/Makefile.in
@@ -347,8 +347,13 @@ gdbreplay.o: gdbreplay.c config.h
 signals.o: ../common/signals.c $(server_h) $(signals_def)
 	$(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< -DGDBSERVER
 
+# We build memmem.c with -Wno-error because this file is not under
+# our control.  On LynxOS, the compiler generates some warnings
+# because str-two-way.h uses a constant (MAX_SIZE) whose definition
+# makes it ambiguous whether it is signed or unsigned ("warning: this
+# decimal constant is unsigned only in ISO C90").
 memmem.o: ../gnulib/memmem.c
-	$(CC) -o memmem.o -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $<
+	$(CC) -o memmem.o -c $(CPPFLAGS) $(INTERNAL_CFLAGS) -Wno-error $<
 
 i386_low_h = $(srcdir)/i386-low.h
 
-- 
1.7.1

             reply	other threads:[~2010-08-31 19:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-31 19:08 Joel Brobecker [this message]
2010-08-31 19:48 ` Pedro Alves
2010-08-31 20:15   ` Jan Kratochvil
2010-08-31 20:34     ` Pedro Alves
2010-08-31 21:22       ` Joel Brobecker
2010-08-31 21:59         ` Pedro Alves
2010-08-31 22:07           ` Joel Brobecker
2010-08-31 22:13             ` Jan Kratochvil
2010-08-31 22:21               ` Pedro Alves
2010-09-02 14:54       ` Jan Kratochvil
2010-08-31 22:04   ` Joel Brobecker
2010-08-31 22:23     ` Pedro Alves
2010-09-01  1:56       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283281706-30409-1-git-send-email-brobecker@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).