[RFA/commit] Minor updates to port gdbserver to LynxOS 5.x

[RFA/commit] Minor updates to port gdbserver to LynxOS 5.x

[Joel Brobecker]

Hello,

The following set of patches make the small adjustments needed in
order to be build gdbserver on LynxOS version 5.x. The changes are
relatively minor, so I'm planning to commit them in a day or two,
pending any comment.

[LynxOS/gdbserver 1/3] Include sys/ptrace.h instead of ptrace.h

[Joel Brobecker]

Really interesting: On LynxOS 4.x, there is a #warning when sys/ptrace.h
is used (explaining that ptrace.h will be used instead), whereas this
file was removed from LynxOS 5.x. The contents of sys/ptrace.h on 4.x
(or at least the meat of it):

    #if defined(__GNUC__) || defined(__GNUG__)
    #if !defined(__NO_INCLUDE_WARN__)
    #warning Using <ptrace.h> instead of <sys/ptrace.h>
    #endif /* defined(__NO_INCLUDE_WARN__) */
    #endif /* defined(__GNUC__) || defined(__GNUG__) */

    #include <ptrace.h>

The fix I went for, for now, is to just include <sys/ptrace.h>
unconditionally.  I could have done some configury, but we already
have to build with -D__NO_INCLUDE_WARN__ to avoid the warnings
anyway, and that's unvoidable, due to system includes themselves
including the "wrong" header file.

Since <sys/ptrace.h> seems to be the choice that was made for LynxOS,
and since it works to include it on LynxOS 4.x, I think that's the simplest
solution.

gdb/gdbserver/ChangeLog:

        * lynx-low.c, lynx-ppc-loc.c: Include <sys/ptrace.h> instead of
        <ptrace.h>
---
 gdb/gdbserver/lynx-low.c     |    2 +-
 gdb/gdbserver/lynx-ppc-low.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/gdbserver/lynx-low.c b/gdb/gdbserver/lynx-low.c
index 7a949c0..74d2bcd 100644
--- a/gdb/gdbserver/lynx-low.c
+++ b/gdb/gdbserver/lynx-low.c
@@ -20,7 +20,7 @@
 #include "lynx-low.h"
 
 #include <limits.h>
-#include <ptrace.h>
+#include <sys/ptrace.h>
 #include <sys/piddef.h> /* Provides PIDGET, TIDGET, BUILDPID, etc.  */
 #include <unistd.h>
 #include <sys/ioctl.h>
diff --git a/gdb/gdbserver/lynx-ppc-low.c b/gdb/gdbserver/lynx-ppc-low.c
index 9caa8ac..97d691a 100644
--- a/gdb/gdbserver/lynx-ppc-low.c
+++ b/gdb/gdbserver/lynx-ppc-low.c
@@ -21,7 +21,7 @@
 #include <stdint.h>
 #include <stddef.h>
 #include <limits.h>
-#include <ptrace.h>
+#include <sys/ptrace.h>
 
 /* The following two typedefs are defined in a .h file which is not
    in the standard include path (/sys/include/family/ppc/ucontext.h),
-- 
1.7.1

[LynxOS/gdbserver 2/3] Remove handling of PTRACE_* values removed in Lynx5.

[Joel Brobecker]

Some of the PTRACE_ macros/values were removed in LynxOS 5.x.
Since we have not use them so far, the chances that we will use them
one day are very small.  So I decided to delete them.

gdb/gdbserver/ChangeLog:

        * lynx-low.c (ptrace_request_to_str): Remove handling for
        request values that have been removed in LynxOS 5.x.
---
 gdb/gdbserver/lynx-low.c |   40 ----------------------------------------
 1 files changed, 0 insertions(+), 40 deletions(-)

diff --git a/gdb/gdbserver/lynx-low.c b/gdb/gdbserver/lynx-low.c
index 74d2bcd..3f18919 100644
--- a/gdb/gdbserver/lynx-low.c
+++ b/gdb/gdbserver/lynx-low.c
@@ -208,16 +208,6 @@ ptrace_request_to_str (int request)
         return "PT_WRITE_FPR";
         break;
 #endif
-#ifdef PTRACE_GETVECREGS
-      case PTRACE_GETVECREGS:
-        return "PTRACE_GETVECREGS";
-        break;
-#endif
-#ifdef PTRACE_SETVECREGS
-      case PTRACE_SETVECREGS:
-        return "PTRACE_SETVECREGS";
-        break;
-#endif
 #ifdef PT_READ_VPR
       case PT_READ_VPR:
         return "PT_READ_VPR";
@@ -268,36 +258,6 @@ ptrace_request_to_str (int request)
       case PTRACE_GETTHREADLIST:
         return "PTRACE_GETTHREADLIST";
         break;
-      case PTRACE_POSTSYSCALL:
-        return "PTRACE_POSTSYSCALL";
-        break;
-      case PTRACE_USE_SIGEXECED:
-        return "PTRACE_USE_SIGEXECED";
-        break;
-      case PTRACE_GETTRACESIG:
-        return "PTRACE_GETTRACESIG";
-        break;
-      case PTRACE_GETCWD:
-        return "PTRACE_GETCWD";
-        break;
-      case PTRACE_TRAPFORK:
-        return "PTRACE_TRAPFORK";
-        break;
-      case PTRACE_GETCHILDPID:
-        return "PTRACE_GETCHILDPID";
-        break;
-      case PTRACE_SYSCALL_ONE:
-        return "PTRACE_SYSCALL_ONE";
-        break;
-      case PTRACE_SIGMASK:
-        return "PTRACE_SIGMASK";
-        break;
-      case PTRACE_GETIWD:
-        return "PTRACE_GETIWD";
-        break;
-      case PTRACE_GETEXECFILE:
-        return "PTRACE_GETEXECFILE";
-        break;
     }
   return "<unknown-request>";
 }
-- 
1.7.1

[LynxOS/gdbserver 3/3] [NEWS] Announce support for PowerPC LynxOS 5.x.

[Joel Brobecker]

This adjusts the news entry about ppc-lynxos to add version 5.x
of the OS to the list of supported versions...

gdb/ChangeLog:

        * NEWS: Announce GDBserver support for version 5.x of ppc-lynxos.
---
 gdb/NEWS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gdb/NEWS b/gdb/NEWS
index 37613aa..57bd6a7 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -64,7 +64,7 @@
 
 * New features in the GDB remote stub, GDBserver
 
-  ** GDBserver is now supported on PowerPC LynxOS 4.x.
+  ** GDBserver is now supported on PowerPC LynxOS 4.x and 5.x.
 
 *** Changes in GDB 7.2
 
-- 
1.7.1

Re: [RFA/commit] Minor updates to port gdbserver to LynxOS 5.x

[Joel Brobecker]

> The following set of patches make the small adjustments needed in
> order to be build gdbserver on LynxOS version 5.x. The changes are
> relatively minor, so I'm planning to commit them in a day or two,
> pending any comment.

FYI: I've checked in the whole series.

-- 
Joel