public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: [RFA/commit] replace strcmp by FILENAME_CMP for filename comparison
Date: Tue, 26 Oct 2010 15:36:00 -0000	[thread overview]
Message-ID: <1288107368-31496-1-git-send-email-brobecker@adacore.com> (raw)
In-Reply-To: <20101026133928.GB2847@adacore.com>

This is a change that I suggested in a (very late) comment:
    http://www.sourceware.org/ml/gdb-patches/2010-08/msg00427.html
    http://www.sourceware.org/ml/gdb-patches/2010-10/msg00363.html

gdb/ChangeLog:

        * dwarf2read.c (psymtab_include_file_name): Replace call to strcmp
        by call to FILENAME_CMP.

Tested on x86_64-linux. Does it look OK?

Thanks,
-- 
Joel

---
 gdb/dwarf2read.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 7c78454..e613d90 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -10087,7 +10087,7 @@ psymtab_include_file_name (const struct line_header *lh, int file_index,
       pst_filename = copied_name;
     }
 
-  file_is_pst = strcmp (include_name_to_compare, pst_filename) == 0;
+  file_is_pst = FILENAME_CMP (include_name_to_compare, pst_filename) == 0;
 
   if (include_name_to_compare != include_name)
     xfree (include_name_to_compare);
-- 
1.7.1

  reply	other threads:[~2010-10-26 15:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25  0:00 [patch] Fix avoiding of unnecessary psymtabs in dwarf_decode_lines Doug Evans
2010-10-26 13:39 ` Joel Brobecker
2010-10-26 15:36   ` Joel Brobecker [this message]
2010-10-26 18:02     ` [RFA/commit] replace strcmp by FILENAME_CMP for filename comparison Joel Brobecker
2010-10-26 15:37   ` [patch] Fix avoiding of unnecessary psymtabs in dwarf_decode_lines Tom Tromey
2010-10-26 17:41   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288107368-31496-1-git-send-email-brobecker@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).