From: Richard Earnshaw <rearnsha@arm.com>
To: Yao Qi <yao@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch, testsuite] General ARM target triplet
Date: Fri, 03 Dec 2010 17:36:00 -0000 [thread overview]
Message-ID: <1291397752.27205.18.camel@e102346-lin.cambridge.arm.com> (raw)
In-Reply-To: <4CF91BD4.7090708@codesourcery.com>
On Sat, 2010-12-04 at 00:33 +0800, Yao Qi wrote:
> diff --git a/gdb/testsuite/gdb.xml/tdesc-regs.exp
> b/gdb/testsuite/gdb.xml/tdesc-regs.exp
> index f37b2f3..64e56ea 100644
> --- a/gdb/testsuite/gdb.xml/tdesc-regs.exp
> +++ b/gdb/testsuite/gdb.xml/tdesc-regs.exp
> @@ -27,7 +27,7 @@ set core-regs ""
> set regdir ""
> set architecture ""
> switch -glob -- [istarget] {
> - "*arm-*-*" {
> + "*arm*-*-*" {
> set core-regs {arm-core.xml}
> }
> "xscale-*-*" {
So I think this is too broad. arm in the middle of a string could match
many things that are not ARM cores at all. I think the original code
dates back to support for StrongARM and someone was being lazy.
It's probably better to make this a specific test for strongarm* and
arm* rather than a very wide-ranging glob.
R.
next prev parent reply other threads:[~2010-12-03 17:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 16:33 Yao Qi
2010-12-03 17:00 ` Joseph S. Myers
2010-12-03 17:36 ` Richard Earnshaw [this message]
2010-12-03 18:05 ` Joseph S. Myers
2010-12-03 18:06 ` Richard Earnshaw
2010-12-05 9:20 ` Yao Qi
2010-12-05 9:39 ` Andreas Schwab
2010-12-05 12:43 ` Yao Qi
2010-12-13 14:07 ` Pedro Alves
2010-12-13 15:29 ` Yao Qi
2010-12-13 15:39 ` Pedro Alves
2010-12-20 6:34 ` Yao Qi
2011-01-06 14:11 ` PING: " Yao Qi
2011-01-13 11:52 ` PING 2: " Yao Qi
2011-01-19 16:15 ` PING 3: " Yao Qi
2011-01-19 18:24 ` Richard Earnshaw
2011-01-19 19:03 ` Ulrich Weigand
2011-01-19 20:43 ` Yao Qi
2011-01-13 14:53 ` PING: " Matthew Gretton-Dann
2011-01-13 15:16 ` Yao Qi
2010-12-05 12:15 ` Yao Qi
2010-12-13 3:52 ` Ping: " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291397752.27205.18.camel@e102346-lin.cambridge.arm.com \
--to=rearnsha@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).