From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-77733-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26389 invoked by alias); 19 Jan 2011 17:27:02 -0000
Received: (qmail 26350 invoked by uid 22791); 19 Jan 2011 17:27:00 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from service87.mimecast.com (HELO service87.mimecast.com) (94.185.240.25)    by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Wed, 19 Jan 2011 17:26:54 +0000
Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21])	by service87.mimecast.com;	Wed, 19 Jan 2011 17:26:50 +0000
Received: from [10.1.67.34] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0);	 Wed, 19 Jan 2011 17:26:49 +0000
Subject: Re: PING 3: [patch, testsuite] General ARM target triplet
From: Richard Earnshaw <rearnsha@arm.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <4D370C8E.8010307@codesourcery.com>
References: <4CF91BD4.7090708@codesourcery.com>	 <201012131407.08185.pedro@codesourcery.com>	 <4D063BA8.4000404@codesourcery.com>	 <201012131539.22392.pedro@codesourcery.com>	 <4D25CD5E.4030204@codesourcery.com> <4D2EE641.1080902@codesourcery.com>	 <4D370C8E.8010307@codesourcery.com>
Date: Wed, 19 Jan 2011 18:24:00 -0000
Message-Id: <1295458009.26870.2.camel@e102346-lin.cambridge.arm.com>
Mime-Version: 1.0
X-MC-Unique: 111011917265001401
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-01/txt/msg00401.txt.bz2


On Wed, 2011-01-19 at 09:08 -0700, Yao Qi wrote:
> On 01/13/2011 04:47 AM, Yao Qi wrote:
> > On 01/06/2011 08:10 AM, Yao Qi wrote:
> >> On 12/13/2010 11:39 PM, Pedro Alves wrote:
> >>>>> OK, I combine them together in one single patch this time.
> >>> Thanks. If/when everyone's happy with the triplet bits
> >>> proper, this is okay.
> >>
> >> Ping. Are you happy with this triplet? :-)
> >>
> >> http://sourceware.org/ml/gdb-patches/2010-12/msg00187.html
> >>
> >
> > Ping.
> >
>=20
> Ping again with a small fix pointed out by Matthew.  Richard, are you OK=
=20
> with that?
>=20
> --=20
> Yao Qi

+proc dwarf2_support {} {
+    if {![istarget *-*-linux*]
+       && ![istarget *-*-gnu*]
+       && ![istarget *-*-elf*]
+       && ![istarget *-*-openbsd*]
+       && ![istarget arm*-*-eabi*]
+       && ![istarget arm*-*-symbianelf*]
+       && ![istarget powerpc-*-eabi*]} {
+       return 0
+    }
+
+    return 1
+}

Why is this negated?  It would seem more sensible to me to have a list
of supported targets that returns 1 and then default to returning 0 for
everything else.  Why?  Because then if the list gets too long its
easier to add a second cluster in an independent if-clause.


The ARM bits are all fine.  The dwarf2 changes look generally sensible,
but should be reviewed by a full gdb maintainer, which I'm not.

R.