[obvious] Fix typos in breakpoint.c and breakpoint.h

[obvious] Fix typos in breakpoint.c and breakpoint.h

[Thiago Jung Bauermann]

Hi,

I just committed the following.
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


2011-02-04  Thiago Jung Bauermann  <bauerman@br.ibm.com>

	Fix some typos.
	* breakpoint.c (update_watchpoint): Fix name of the
	update_global_location_list function.
	(print_one_breakpoint): Fix typo.
	(_initialize_breakpoint): Remove extra space in hbreak help
	string.
	* breakpoint.h (struct bp_location) <length>: Fix field
	description.

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 1fad517..656dedd 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -1374,8 +1374,8 @@ update_watchpoint (struct breakpoint *b, int reparse)
   if (!watchpoint_in_thread_scope (b))
     return;
 
-  /* We don't free locations.  They are stored in bp_location array
-     and update_global_locations will eventually delete them and
+  /* We don't free locations.  They are stored in the bp_location array
+     and update_global_location_list will eventually delete them and
      remove breakpoints if needed.  */
   b->loc = NULL;
 
@@ -5012,7 +5012,7 @@ print_one_breakpoint (struct breakpoint *b,
 	 situation.
 
 	 Note that while hardware watchpoints have several locations
-	 internally, that's no a property exposed to user.  */
+	 internally, that's not a property exposed to user.  */
       if (b->loc 
 	  && !is_hardware_watchpoint (b)
 	  && (b->loc->next || !b->loc->enabled)
@@ -12097,7 +12097,7 @@ BREAK_ARGS_HELP ("tbreak")));
   set_cmd_completer (c, location_completer);
 
   c = add_com ("hbreak", class_breakpoint, hbreak_command, _("\
-Set a hardware assisted  breakpoint.\n\
+Set a hardware assisted breakpoint.\n\
 Like \"break\" except the breakpoint requires hardware support,\n\
 some target hardware may not have this support.\n\
 \n"
diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
index 2644125..86fae66 100644
--- a/gdb/breakpoint.h
+++ b/gdb/breakpoint.h
@@ -324,8 +324,8 @@ struct bp_location
      bp_loc_other.  */
   CORE_ADDR address;
 
-  /* For hardware watchpoints, the size of data ad ADDRESS being
-     watches.  */
+  /* For hardware watchpoints, the size of the memory region being
+     watched.  */
   int length;
 
   /* Type of hardware watchpoint.  */

Re: [obvious] Fix typos in breakpoint.c and breakpoint.h

[Paul Pluzhnikov]

On Fri, Feb 4, 2011 at 9:30 AM, Thiago Jung Bauermann
<bauerman@br.ibm.com> wrote:

> I just committed the following.
...
> 2011-02-04  Thiago Jung Bauermann  <bauerman@br.ibm.com>
>
>        Fix some typos.
>        * breakpoint.c (update_watchpoint): Fix name of the
>        update_global_location_list function.
>        (print_one_breakpoint): Fix typo.
>        (_initialize_breakpoint): Remove extra space in hbreak help
>        string.
>        * breakpoint.h (struct bp_location) <length>: Fix field
>        description.

AFAICT, both above and subsequent change on 02/07 are missing from ChangeLog

Do obvious commits not require ChangeLog entries?

Thanks,
-- 
Paul Pluzhnikov

Re: [obvious] Fix typos in breakpoint.c and breakpoint.h

[Tom Tromey]

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Paul> Do obvious commits not require ChangeLog entries?

They do.

I think fixing a bad ChangeLog commit is maybe the only change not
requiring a ChangeLog entry.

Tom

Re: [obvious] Fix typos in breakpoint.c and breakpoint.h

[Paul Pluzhnikov]

On Tue, Feb 15, 2011 at 10:41 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
>
> Paul> Do obvious commits not require ChangeLog entries?
>
> They do.

Thanks.

> I think fixing a bad ChangeLog commit is maybe the only change not
> requiring a ChangeLog entry.

Ah, but Thiago's ChangeLog entries are in fact present -- I just had a sticky
date to work around the incomplete commit from a week ago.

Sorry about the noise.


-- 
Paul Pluzhnikov