From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8368 invoked by alias); 12 Mar 2011 02:17:54 -0000 Received: (qmail 8352 invoked by uid 22791); 12 Mar 2011 02:17:53 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp03.br.ibm.com (HELO e24smtp03.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 12 Mar 2011 02:17:49 +0000 Received: from /spool/local by e24smtp03.br.ibm.com with XMail ESMTP for from ; Fri, 11 Mar 2011 23:17:46 -0300 Received: from mailhub1.br.ibm.com ([9.18.232.109]) by e24smtp03.br.ibm.com ([10.172.0.139]) with XMail ESMTP; Fri, 11 Mar 2011 23:17:44 -0300 Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.8.31.91]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p2C2I1j41364398 for ; Fri, 11 Mar 2011 23:18:01 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2C0HfMC013626 for ; Fri, 11 Mar 2011 21:17:42 -0300 Received: from [9.12.229.93] ([9.12.229.93]) by d24av01.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p2C0He71013607; Fri, 11 Mar 2011 21:17:40 -0300 Subject: Re: [RFA] Implement support for PowerPC BookE ranged breakpoints From: Thiago Jung Bauermann To: Ulrich Weigand Cc: gdb-patches ml In-Reply-To: <1299890187.9288.185.camel@hactar> References: <201102281652.p1SGqseO021809@d06av02.portsmouth.uk.ibm.com> <1299890187.9288.185.camel@hactar> Content-Type: text/plain; charset="UTF-8" Date: Sat, 12 Mar 2011 16:44:00 -0000 Message-ID: <1299896013.9288.189.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit x-cbid: 11031202-9254-0000-0000-000000E1E99D X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00694.txt.bz2 On Fri, 2011-03-11 at 21:36 -0300, Thiago Jung Bauermann wrote: > On Mon, 2011-02-28 at 17:52 +0100, Ulrich Weigand wrote: > > Do we really need to make a new ui_out_ function for this; this > > seems a bit of a special case for that. Why don't you just generate > > the output here? (Note that here you might want to use a temporary > > stream like the one you had in the above functions but never used > > there ...) > > I think I was using that function somewhere else in a previous > incarnation of this patch series, so it stayed. I didn't think it was a > problem since it is analogous to other functions in ui-out.c. I forgot to mention that in this version I don't add a new ui_out_ function and instead use ui_out_field_fmt in print_one_detail_ranged_breakpoint. I didn't even need a temporary stream. -- []'s Thiago Jung Bauermann IBM Linux Technology Center