From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id A7647382E071 for ; Wed, 15 Jul 2020 18:30:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A7647382E071 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0F0BBB1C8; Wed, 15 Jul 2020 18:30:20 +0000 (UTC) Subject: Re: [PATCH] Fix build with GNU Make 3.81 To: Simon Marchi , Bernd Edlinger , "gdb-patches@sourceware.org" Cc: Tom Tromey , Alan Hayward , Kevin Buettner , Eli Zaretskii References: <05bc8ac7-816d-5bc4-b3ed-80580341053d@suse.de> <071c6225-0704-8e1f-df78-8a574bfff449@simark.ca> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <12ab0278-62ba-6a47-5227-cad0e97aa87e@suse.de> Date: Wed, 15 Jul 2020 20:30:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <071c6225-0704-8e1f-df78-8a574bfff449@simark.ca> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_NUMSUBJECT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2020 18:30:19 -0000 On 7/15/20 3:44 PM, Simon Marchi wrote: > On 2020-07-15 4:19 a.m., Tom de Vries wrote: >> I don't follow this reasoning. >> >> There's a bug in make 3.81, which we run into with the gdb build. >> >> We then require make 3.82, such that gdb builds again for all supported >> make versions. >> >> Subsequently (that is, 3 days later) we work around the bug in make 3.81 >> with a gdb commit. >> >> But we decide to still require make 3.82, even if the original reason to >> do so is no longer valid, and I'm assuming we haven't started using make >> 3.82 features in the 3 days inbetween. >> >> Are there other considerations at play here, that are not being made >> explicit? >> >> Because if there are not, we should update NEWS to say we support 3.81 >> again. >> >> Thanks, >> - Tom >> > > Hi Tom, > > Requiring make 3.82 was based on the assumption that pretty much all supported > versions of major distros had 3.82 bundled (which turned out false for SLES11). Yeah. And looking here ( https://en.wikipedia.org/wiki/SUSE_Linux_Enterprise_Server#End-of-support_schedule ), that's still supported till 31 March 2022. > So the simplest thing to do when it was found that GDB wouldn't build with 3.81 > was just to say "don't use 3.81", rather than trying to work around the bug. > Right, that made sense at that point. > Even with the claim that we require make 3.82, if somebody provides a simple fix > (like Bernd did) to make it work again with 3.81, then I'm happy to merge it. It > makes his life easier, and it doesn't affect mine. > Agreed. > If we claim in NEWS that we support 3.81 again, then we ideally have to test it > regularly and take care of any breakage. Test it, yes. Take care of any breakage, if it's reasonable for upstream sources. If not, we always have the option of requiring 3.82 at that point. > That's not something I want to do, but > if it is something you need to support (because you need to support SLES11) and > are ready to take care of that support, then I have nothing against it. Sure, I can set make 3.81 as my default make for development builds, and I should at least encounter any breakage that way. Anyways, I understand now, the decision to move to 3.82 was triggered by the 3.81 build breaker, but based on the assumption that 3.81 was not provided by any of the major distros so nobody would need to test and support it, and when the build breaker got fixed, that reasoning didn't change. It all makes sense to me now, thanks for elaborating. Thanks, - Tom