From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6782 invoked by alias); 1 Mar 2012 02:02:33 -0000 Received: (qmail 6413 invoked by uid 22791); 1 Mar 2012 02:02:31 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Mar 2012 02:02:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E19751C6B0C; Wed, 29 Feb 2012 21:02:10 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id cJ0K8h7a5QG9; Wed, 29 Feb 2012 21:02:10 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 425A01C6B09; Wed, 29 Feb 2012 21:02:10 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C705E145615; Wed, 29 Feb 2012 18:02:02 -0800 (PST) From: Joel Brobecker To: gdb-patches@sourceware.org Cc: Joel Brobecker Subject: [commit] remove dead code in varobj.c:c_value_of_variable Date: Thu, 01 Mar 2012 02:02:00 -0000 Message-Id: <1330567321-12594-1-git-send-email-brobecker@adacore.com> In-Reply-To: References: Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00003.txt.bz2 This patch removes some dead code identified in: http://www.sourceware.org/ml/gdb-patches/2012-01/msg00266.html (and analysis confirmed by Tom). gdb/ChangeLog: * varobj.c (c_value_of_variable): Remove dead code. Tested on x86_64-linux. Checked in. --- gdb/ChangeLog | 4 ++++ gdb/varobj.c | 5 ----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 621da5b..cb9eecb 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2012-02-29 Joel Brobecker + * varobj.c (c_value_of_variable): Remove dead code. + +2012-02-29 Joel Brobecker + * ada-lex.p (processId): Do not modify already encoded IDs. Update function documentation. diff --git a/gdb/varobj.c b/gdb/varobj.c index abe832c..cb05128 100644 --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -3400,11 +3400,6 @@ c_value_of_variable (struct varobj *var, enum varobj_display_formats format) catch that case explicitly. */ struct type *type = get_type (var); - /* If we have a custom formatter, return whatever string it has - produced. */ - if (var->pretty_printer && var->print_value) - return xstrdup (var->print_value); - /* Strip top-level references. */ while (TYPE_CODE (type) == TYPE_CODE_REF) type = check_typedef (TYPE_TARGET_TYPE (type)); -- 1.7.1