From: markus.t.metzger@intel.com
To: gdb-patches@sourceware.org
Cc: markus.t.metzger@gmail.com, Markus Metzger <markus.t.metzger@intel.com>
Subject: [PATCH 02/16] source: add flags to print_source_lines ()
Date: Thu, 10 May 2012 15:17:00 -0000 [thread overview]
Message-ID: <1336662810-21937-3-git-send-email-markus.t.metzger@intel.com> (raw)
In-Reply-To: <1336662810-21937-1-git-send-email-markus.t.metzger@intel.com>
From: Markus Metzger <markus.t.metzger@intel.com>
The 4th parameter of print_source_lines is a boolean flag noerror. Generalize
this to be a bit vector of flags and make noerror one of the flag bits.
2012-05-10 Markus Metzger <markus.t.metzger@intel.com>
gdb/
* symtab.h (print_source_lines_flags): New enum
* source.c (print_source_lines_base): Change noerror to flags
(print_source_lines): Change noerror to flags
---
gdb/source.c | 14 ++++++--------
gdb/symtab.h | 5 +++++
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/gdb/source.c b/gdb/source.c
index 27c5b0e..4dd7ed2 100644
--- a/gdb/source.c
+++ b/gdb/source.c
@@ -1225,10 +1225,8 @@ identify_source_line (struct symtab *s, int line, int mid_statement,
/* Print source lines from the file of symtab S,
starting with line number LINE and stopping before line number STOPLINE. */
-static void print_source_lines_base (struct symtab *s, int line, int stopline,
- int noerror);
static void
-print_source_lines_base (struct symtab *s, int line, int stopline, int noerror)
+print_source_lines_base (struct symtab *s, int line, int stopline, int flags)
{
int c;
int desc;
@@ -1256,13 +1254,13 @@ print_source_lines_base (struct symtab *s, int line, int stopline, int noerror)
else
{
desc = last_source_error;
- noerror = 1;
+ flags |= PRINT_SOURCE_LINES_NOERROR;
}
}
else
{
desc = last_source_error;
- noerror = 1;
+ flags |= PRINT_SOURCE_LINES_NOERROR;
noprint = 1;
}
@@ -1270,7 +1268,7 @@ print_source_lines_base (struct symtab *s, int line, int stopline, int noerror)
{
last_source_error = desc;
- if (!noerror)
+ if (!(flags & PRINT_SOURCE_LINES_NOERROR))
{
char *name = alloca (strlen (s->filename) + 100);
sprintf (name, "%d\t%s", line, s->filename);
@@ -1356,9 +1354,9 @@ print_source_lines_base (struct symtab *s, int line, int stopline, int noerror)
window otherwise it is simply printed. */
void
-print_source_lines (struct symtab *s, int line, int stopline, int noerror)
+print_source_lines (struct symtab *s, int line, int stopline, int flags)
{
- print_source_lines_base (s, line, stopline, noerror);
+ print_source_lines_base (s, line, stopline, flags);
}
\f
/* Print info on range of pc's in a specified line. */
diff --git a/gdb/symtab.h b/gdb/symtab.h
index 61e7c0f..b252725 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -1126,6 +1126,11 @@ extern void clear_solib (void);
extern int identify_source_line (struct symtab *, int, int, CORE_ADDR);
+/* Flags passed as 4th argument to print_source_lines. */
+enum print_source_lines_flags {
+ PRINT_SOURCE_LINES_NOERROR = (0x1 << 0)
+};
+
extern void print_source_lines (struct symtab *, int, int, int);
extern void forget_cached_source_info_for_objfile (struct objfile *);
--
1.7.1
next prev parent reply other threads:[~2012-05-10 15:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 15:15 [PATCH 00/16] branch tracing support markus.t.metzger
2012-05-10 15:16 ` [PATCH 01/16] disas: add precise instructions flag markus.t.metzger
2012-05-10 15:16 ` [PATCH 05/16] cli, btrace: add btrace cli markus.t.metzger
2012-05-10 16:44 ` Eli Zaretskii
2012-05-11 8:17 ` Metzger, Markus T
2012-05-10 15:17 ` [PATCH 14/16] remote, btrace: add branch trace remote ops markus.t.metzger
2012-05-10 15:17 ` [PATCH 10/16] btrace, config: enable btrace for 32bit and 64bit linux native markus.t.metzger
2012-05-10 15:17 ` [PATCH 03/16] source, disasm: optionally prefix source lines with filename markus.t.metzger
2012-05-10 15:17 ` [PATCH 07/16] configure: autoreconf markus.t.metzger
2012-05-10 15:17 ` [PATCH 16/16] gdbserver, linux, btrace: add btrace support for linux-low markus.t.metzger
2012-05-10 15:17 ` [PATCH 08/16] linux, btrace: perf_event based branch tracing markus.t.metzger
2012-05-10 15:17 ` [PATCH 04/16] thread, btrace: add generic branch trace support markus.t.metzger
2012-05-10 15:17 ` [PATCH 11/16] test, btrace: add branch trace tests markus.t.metzger
2012-05-10 15:17 ` markus.t.metzger [this message]
2012-05-10 15:18 ` [PATCH 15/16] gdbserver, btrace: add generic btrace support markus.t.metzger
2012-05-10 15:18 ` [PATCH 09/16] btrace, linux: add linux native btrace target ops markus.t.metzger
2012-05-10 15:18 ` [PATCH 06/16] configure: add check for perf_event header markus.t.metzger
2012-05-10 15:18 ` [PATCH 12/16] test, btrace: more branch tracing tests markus.t.metzger
2012-05-10 15:18 ` [PATCH 13/16] xml, btrace: define btrace xml document style markus.t.metzger
2012-05-11 0:25 ` [PATCH 00/16] branch tracing support Hui Zhu
2012-05-11 8:17 ` Metzger, Markus T
2012-05-23 11:23 [PATCH 00/16] branch tracing support (resend) markus.t.metzger
2012-05-23 11:24 ` [PATCH 02/16] source: add flags to print_source_lines () markus.t.metzger
2012-05-30 20:41 ` Jan Kratochvil
2012-05-31 15:34 ` Metzger, Markus T
2012-06-22 20:08 ` Tom Tromey
2012-06-25 8:50 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336662810-21937-3-git-send-email-markus.t.metzger@intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).