From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30771 invoked by alias); 29 Jul 2013 08:46:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30667 invoked by uid 89); 29 Jul 2013 08:46:45 -0000 X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_50,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 29 Jul 2013 08:46:45 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1V3j6D-0001Jm-IK from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Mon, 29 Jul 2013 01:46:37 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 29 Jul 2013 01:46:37 -0700 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Mon, 29 Jul 2013 01:46:36 -0700 From: Yao Qi To: Subject: [PATCH 2/3] Unbuffer stdout and stderr in cygwin Date: Mon, 29 Jul 2013 08:46:00 -0000 Message-ID: <1375087546-22591-3-git-send-email-yao@codesourcery.com> In-Reply-To: <1375087546-22591-1-git-send-email-yao@codesourcery.com> References: <1375087546-22591-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00693.txt.bz2 Hi, This patch is to disable the buffering on mingw32 host when it is running in cygwin, because the error message and gdb prompt come out in different orders, which causes a lot of test fails. We call setvbuf this place, because it is a place "before any other operation is performed". See the doc below: "The setvbuf() function may be used after the stream pointed to by stream is associated with an open file but before any other operation (other than an unsuccessful call to setvbuf()) is performed on the stream." It is not the first time this patch show up here. Daniel posted it http://sourceware.org/ml/gdb-patches/2009-06/msg00433.html and Joel preferred it as the exact same piece of code is in their tree as well http://sourceware.org/ml/gdb-patches/2009-06/msg00434.html Eli wanted to check this patch didn't interfere with Emacs 23 GDB interface on Windows, which is probably the last question to this patch. The discussion stopped there. I build native mingw32 gdb with buffering disabled, and use it with Emacs 24.3 in Windows cmd.exe. Emacs+GDB behave correctly. gdb: 2013-07-29 Joseph Myers Yao Qi * main.c (captured_main) [__MINGW32__]: Set stdout and stderr unbuffered if GDB is running in Cygwin. --- gdb/main.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/gdb/main.c b/gdb/main.c index 440094e..4fa211e 100644 --- a/gdb/main.c +++ b/gdb/main.c @@ -375,6 +375,18 @@ captured_main (void *data) saved_command_line[0] = '\0'; instream = stdin; +#ifdef __MINGW32__ + if (is_in_cygwin_p ()) + { + /* A Cygwin session may not look like a terminal to the Windows + runtime; ensure unbuffered output. Note that setvbuf may be + used after the file is opened but before any other operation + is performed. */ + setvbuf (stdout, NULL, _IONBF, BUFSIZ); + setvbuf (stderr, NULL, _IONBF, BUFSIZ); + } +#endif + gdb_stdout = stdio_fileopen (stdout); gdb_stderr = stdio_fileopen (stderr); gdb_stdlog = gdb_stderr; /* for moment */ -- 1.7.7.6