public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Sanimir Agovic <sanimir.agovic@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 06/10] vla: update type from newly created value
Date: Mon, 21 Oct 2013 14:40:00 -0000	[thread overview]
Message-ID: <1382366424-21010-7-git-send-email-sanimir.agovic@intel.com> (raw)
In-Reply-To: <1382366424-21010-1-git-send-email-sanimir.agovic@intel.com>

Constructing a value based on a type and address might change the type
of the newly constructed value. Thus re-fetch type via value_type to ensure
we have the correct type at hand.

2013-10-18  Sanimir Agovic  <sanimir.agovic@intel.com>
            Keven Boell  <keven.boell@intel.com>

	* valops.c (value_ind): Re-fetch type from value.
	* value.c (coerce_ref): Re-fetch type from value.

Change-Id: Ice9ae63215f637c4b99babf0f108e7b5b58988cd
---
 gdb/valops.c |    1 +
 gdb/value.c  |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gdb/valops.c b/gdb/valops.c
index 15fd7c3..6706d9f 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1610,6 +1610,7 @@ value_ind (struct value *arg1)
 			      (value_as_address (arg1)
 			       - value_pointed_to_offset (arg1)));
 
+      enc_type = value_type (arg2);
       return readjust_indirect_value_type (arg2, enc_type, base_type, arg1);
     }
 
diff --git a/gdb/value.c b/gdb/value.c
index b9266db..ce778ea 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -3360,6 +3360,7 @@ coerce_ref (struct value *arg)
   retval = value_at_lazy (enc_type,
                           unpack_pointer (value_type (arg),
                                           value_contents (arg)));
+  enc_type = value_type (retval);
   return readjust_indirect_value_type (retval, enc_type,
                                        value_type_arg_tmp, arg);
 }
-- 
1.7.0.7

  parent reply	other threads:[~2013-10-21 14:40 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 14:40 C99 variable length array support Sanimir Agovic
2013-10-21 14:40 ` [PATCH 01/10] vla: introduce new bound type abstraction adapt uses Sanimir Agovic
2013-11-07 19:00   ` Tom Tromey
2013-11-18 11:15     ` Agovic, Sanimir
2013-10-21 14:40 ` [PATCH 08/10] test: multi-dimensional c99 vla Sanimir Agovic
2013-11-07 21:19   ` Tom Tromey
2013-10-21 14:40 ` [PATCH 04/10] vla: enable sizeof operator for indirection Sanimir Agovic
2013-11-07 19:57   ` Tom Tromey
2013-10-21 14:40 ` Sanimir Agovic [this message]
2013-11-07 20:56   ` [PATCH 06/10] vla: update type from newly created value Tom Tromey
2013-11-20  7:56     ` Agovic, Sanimir
2013-11-20 11:02   ` Pedro Alves
2013-11-20 13:08     ` Agovic, Sanimir
2013-11-21 18:50       ` Pedro Alves
2013-11-23 19:27     ` Doug Evans
2013-10-21 14:40 ` [PATCH 09/10] test: basic c99 vla tests Sanimir Agovic
2013-11-07 21:23   ` Tom Tromey
2013-10-21 14:40 ` [PATCH 10/10] test: add mi vla test Sanimir Agovic
2013-11-07 21:31   ` Tom Tromey
2013-10-21 14:40 ` [PATCH 03/10] vla: enable sizeof operator to work with variable length arrays Sanimir Agovic
2013-11-07 19:10   ` Tom Tromey
2013-10-21 14:40 ` [PATCH 05/10] vla: allow side effects for sizeof argument Sanimir Agovic
2013-10-24 19:55   ` Tom Tromey
2013-10-25  8:13     ` Agovic, Sanimir
2013-10-28 21:00       ` Tom Tromey
2013-11-18  9:37         ` Agovic, Sanimir
2013-11-18 15:56           ` Tom Tromey
2013-11-20 12:18             ` Agovic, Sanimir
2013-11-19 17:08           ` Pedro Alves
2013-11-20 12:47             ` Agovic, Sanimir
2013-11-20 13:24               ` Pedro Alves
2013-10-21 14:40 ` [PATCH 02/10] type: add c99 variable length array support Sanimir Agovic
2013-11-07 19:02   ` Tom Tromey
2013-11-19 15:31     ` Agovic, Sanimir
2013-11-22 20:00       ` Tom Tromey
2013-11-27 17:08         ` Agovic, Sanimir
     [not found]         ` <0377C58828D86C4588AEEC42FC3B85A7176BC3DE@IRSMSX105.ger.corp.intel.com>
2013-11-27 17:15           ` Agovic, Sanimir
2013-11-07 19:10   ` Tom Tromey
2013-10-21 14:40 ` [PATCH 07/10] test: evaluate pointers to C99 vla correctly Sanimir Agovic
2013-11-07 20:57   ` Tom Tromey
2013-11-08  6:37     ` Tom Tromey
2013-11-07 21:14   ` Tom Tromey
2013-11-21 18:52 ` C99 variable length array support Pedro Alves
2013-11-21 19:01   ` Pedro Alves
2013-11-21 19:10     ` Pedro Alves
2013-11-22 10:53       ` Agovic, Sanimir
2013-11-22 12:35         ` Pedro Alves
2013-11-22 17:06           ` Agovic, Sanimir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382366424-21010-7-git-send-email-sanimir.agovic@intel.com \
    --to=sanimir.agovic@intel.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).