From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12816 invoked by alias); 11 Nov 2013 13:16:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12805 invoked by uid 89); 11 Nov 2013 13:16:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_05,RDNS_NONE autolearn=no version=3.3.2 X-HELO: e24smtp02.br.ibm.com Received: from Unknown (HELO e24smtp02.br.ibm.com) (32.104.18.86) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 11 Nov 2013 13:16:09 +0000 Received: from /spool/local by e24smtp02.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 11 Nov 2013 11:15:59 -0200 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp02.br.ibm.com (10.172.0.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 11 Nov 2013 11:15:56 -0200 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 8A4E035200BB for ; Mon, 11 Nov 2013 08:15:37 -0500 (EST) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.8.31.91]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rABDFe4p807100 for ; Mon, 11 Nov 2013 11:15:41 -0200 Received: from d24av01.br.ibm.com (localhost [127.0.0.1]) by d24av01.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rABDFVrR007174 for ; Mon, 11 Nov 2013 11:15:31 -0200 Received: from grandaddy.ibm.com ([9.78.148.116]) by d24av01.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id rABDFUXx007131 for ; Mon, 11 Nov 2013 11:15:30 -0200 From: Edjunior Barbosa Machado To: gdb-patches@sourceware.org Subject: =?UTF-8?q?=5BPATCH=5D=5Bcommit/obvious=5D=20Fix=20argument=20type=20on=20gdbsim=5Fdetach=20prototype=2E?= Date: Mon, 11 Nov 2013 14:18:00 -0000 Message-Id: <1384175693-18100-1-git-send-email-emachado@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13111113-2194-0000-0000-0000071B826C X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00288.txt.bz2 Hi, gdb ppc64 build was failing with the following: gcc -g3 -mminimal-toc -I. -I../../gdb -I../../gdb/common -I../../gdb/config -DLOCALEDIR="\"/usr/share/locale\"" -DHAVE_CONFIG_H -I../../gdb/../include/opcode -I../../gdb/../opcodes/.. -I../../gdb/../readline/.. -I../bfd -I../../gdb/../bfd -I../../gdb/../include -I../libdecnumber -I../../gdb/../libdecnumber -I../../gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.6 -I/usr/include/python2.6 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o remote-sim.o -MT remote-sim.o -MMD -MP -MF .deps/remote-sim.Tpo ../../gdb/remote-sim.c ../../gdb/remote-sim.c:820: error: conflicting types for ‘gdbsim_detach’ ../../gdb/remote-sim.c:81: note: previous declaration of ‘gdbsim_detach’ was here make[2]: *** [remote-sim.o] Error 1 I've checked in the obvious patch below that fixed the problem. Thanks, -- Edjunior 2013-11-11 Edjunior Barbosa Machado * remote-sim.c (gdbsim_detach): Fix prototype. --- gdb/ChangeLog | 4 ++++ gdb/remote-sim.c | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c index e095035..f7be6fa 100644 --- a/gdb/remote-sim.c +++ b/gdb/remote-sim.c @@ -78,7 +78,7 @@ static void gdbsim_open (char *args, int from_tty); static void gdbsim_close (void); -static void gdbsim_detach (struct target_ops *ops, char *args, int from_tty); +static void gdbsim_detach (struct target_ops *ops, const char *args, int from_tty); static void gdbsim_prepare_to_store (struct regcache *regcache); -- 1.7.1