From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [PATCH 1/4] comment fixes
Date: Tue, 03 Dec 2013 19:47:00 -0000 [thread overview]
Message-ID: <1386100019-27379-2-git-send-email-tromey@redhat.com> (raw)
In-Reply-To: <1386100019-27379-1-git-send-email-tromey@redhat.com>
This fixes up a few mildly erroneous comments in probe.h.
2013-12-03 Tom Tromey <tromey@redhat.com>
* probe.h (parse_probes, find_probe_by_pc)
(find_probes_in_objfile): Fix comments.
---
gdb/ChangeLog | 5 +++++
gdb/probe.h | 13 ++++++-------
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/gdb/probe.h b/gdb/probe.h
index dd5387b..d116274 100644
--- a/gdb/probe.h
+++ b/gdb/probe.h
@@ -181,8 +181,7 @@ struct probe
};
/* A helper for linespec that decodes a probe specification. It returns a
- symtabs_and_lines object and updates *ARGPTR or throws an error. The
- argument PTYPE specifies the type of the probe(s) to be parsed. */
+ symtabs_and_lines object and updates *ARGPTR or throws an error. */
extern struct symtabs_and_lines parse_probes (char **argptr,
struct linespec_result *canon);
@@ -192,14 +191,14 @@ extern struct symtabs_and_lines parse_probes (char **argptr,
extern void register_probe_ops (struct probe *probe);
-/* Given a PC, find an associated probe with type PTYPE. If a probe is
- found, return it. If no probe is found, return NULL. */
+/* Given a PC, find an associated probe. If a probe is found, return
+ it. If no probe is found, return NULL. */
extern struct probe *find_probe_by_pc (CORE_ADDR pc);
-/* Search OBJFILE for a probe with the given PROVIDER, NAME and PTYPE.
- Return a VEC of all probes that were found. If no matching probe
- is found, return NULL. The caller must free the VEC. */
+/* Search OBJFILE for a probe with the given PROVIDER, NAME. Return a
+ VEC of all probes that were found. If no matching probe is found,
+ return NULL. The caller must free the VEC. */
extern VEC (probe_p) *find_probes_in_objfile (struct objfile *objfile,
const char *provider,
--
1.8.1.4
next prev parent reply other threads:[~2013-12-03 19:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 19:47 [PATCH 0/4] make probes independent of the program space Tom Tromey
2013-12-03 19:47 ` [PATCH 3/4] change probes to be program-space-independent Tom Tromey
2013-12-17 11:08 ` Gary Benson
2013-12-03 19:47 ` Tom Tromey [this message]
2013-12-03 19:47 ` [PATCH 2/4] remove some sym_probe_fns methods Tom Tromey
2013-12-05 23:06 ` Sergio Durigan Junior
2013-12-06 2:25 ` Sergio Durigan Junior
2013-12-06 15:54 ` Tom Tromey
2013-12-06 17:26 ` Tom Tromey
2013-12-06 18:23 ` Sergio Durigan Junior
2013-12-03 20:37 ` [PATCH 4/4] move probes to be per-bfd Tom Tromey
2013-12-05 17:10 ` [PATCH 0/4] make probes independent of the program space Pedro Alves
2013-12-05 19:10 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386100019-27379-2-git-send-email-tromey@redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).