From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 0/4] Change 'len' of to_xfer_partial to ULONGEST
Date: Wed, 08 Jan 2014 07:29:00 -0000 [thread overview]
Message-ID: <1389166060-434-1-git-send-email-yao@codesourcery.com> (raw)
Hi,
This patch series is a preparation for the changes mentioned in the
discussion on changing target_ops method to_xfer_partial [1], in which,
the expected change would be
LONGEST (*to_xfer_partial) (struct target_ops *ops,
enum target_object object, const char *annex,
gdb_byte *readbuf, const gdb_byte *writebuf,
ULONGEST offset, LONGEST len);
to
enum target_xfer_status (*to_xfer_partial) (struct target_ops *ops,
enum target_object object, const char *annex,
gdb_byte *readbuf, const gdb_byte *writebuf,
ULONGEST offset, ULONGEST len, ULONGEST *xfered_len);
I started from the 'len' "LONGEST -> ULONGEST" transition, and that
is what this patch series tries to do. This change is quite mechanical.
Regression tested on x86_64-linux with both native and gdbserver. I
also rebuilt GDB in the following ways:
- on x86-linux, with all targets enabled,
- cross build native mingw32,mips-linux,hurd,sparc-linux, gdb on
linux,
- build native powerpc-linux gdb on gcc110
- build spu-elf target on gcc110
- build aix native gdb on gcc111
- build native gdb for netbsd on gcc70
There are still some native targets uncovered, such as darwin, but it
should be easy to fix the build error. Patch 2 is major part of this
series. Patch 3 adjusts linux_common_xfer_osdata and patch 4 adjusts
two gdbarch methods.
I tried to turn -Wconversion on to help me to check some signed/unsigned
conversion, but it gives me thousands of errors in a clean build
(without my patches. Looks signed/unsigned types are used freely in GDB
code base, so I didn't take much care of signed/unsigned conversion.
I'll finish the interface to_xfer_partial change in next step, and
adjust its implementations on some targets, such as tfile and ctf
targets.
[1] supporting all kinds of partially-<unavailable> enum target_object types
https://sourceware.org/ml/gdb-patches/2013-10/msg00761.html
*** BLURB HERE ***
Yao Qi (4):
Use target_xfer_partial_ftype for rs6000_xfer_shared_libraries
Change to_xfer_partial 'len' type to ULONGEST.
Change 'len' of linux_common_xfer_osdata to ULONGEST.
Change 'len''s type from LONGEST to ULONGEST: gdbarch methods
core_xfer_shared_libraries and core_xfer_shared_libraries_aix
gdb/aix-thread.c | 2 +-
gdb/auxv.c | 11 +++++++----
gdb/bfd-target.c | 2 +-
gdb/bsd-kvm.c | 2 +-
gdb/bsd-uthread.c | 2 +-
gdb/common/linux-osdata.c | 22 +++++++++++-----------
gdb/common/linux-osdata.h | 2 +-
gdb/corelow.c | 2 +-
gdb/ctf.c | 2 +-
gdb/darwin-nat.c | 12 ++++++------
gdb/exec.c | 6 +++---
gdb/exec.h | 2 +-
gdb/gdbarch.c | 4 ++--
gdb/gdbarch.h | 8 ++++----
gdb/gdbarch.sh | 4 ++--
gdb/gnu-nat.c | 8 ++++----
gdb/i386-cygwin-tdep.c | 2 +-
gdb/ia64-hpux-nat.c | 6 +++---
gdb/ia64-linux-nat.c | 2 +-
gdb/inf-ptrace.c | 2 +-
gdb/inf-ttrace.c | 2 +-
gdb/linux-nat.c | 12 ++++++------
gdb/monitor.c | 4 ++--
gdb/procfs.c | 2 +-
gdb/record-full.c | 4 ++--
gdb/remote-sim.c | 13 +++++++------
gdb/remote.c | 2 +-
gdb/rs6000-aix-tdep.c | 4 ++--
gdb/rs6000-aix-tdep.h | 2 +-
gdb/rs6000-nat.c | 9 +++------
gdb/sol-thread.c | 2 +-
gdb/sparc-nat.c | 4 ++--
gdb/spu-linux-nat.c | 4 ++--
gdb/spu-multiarch.c | 2 +-
gdb/target.c | 16 ++++++++--------
gdb/target.h | 4 ++--
gdb/tracepoint.c | 2 +-
gdb/windows-nat.c | 10 +++++-----
38 files changed, 101 insertions(+), 100 deletions(-)
--
1.7.7.6
next reply other threads:[~2014-01-08 7:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 7:29 Yao Qi [this message]
2014-01-08 7:29 ` [PATCH 2/4] Change to_xfer_partial 'len' type " Yao Qi
2014-01-08 12:34 ` Pedro Alves
2014-01-08 15:31 ` Yao Qi
2014-01-08 7:29 ` [PATCH 4/4] Change 'len''s type from LONGEST to ULONGEST: gdbarch methods core_xfer_shared_libraries and core_xfer_shared_libraries_aix Yao Qi
2014-01-08 12:35 ` Pedro Alves
2014-01-08 7:29 ` [PATCH 1/4] Use target_xfer_partial_ftype for rs6000_xfer_shared_libraries Yao Qi
2014-01-08 7:49 ` Joel Brobecker
2014-01-08 7:29 ` [PATCH 3/4] Change 'len' of linux_common_xfer_osdata to ULONGEST Yao Qi
2014-01-08 12:35 ` Pedro Alves
2014-01-08 12:38 ` [PATCH 0/4] Change 'len' of to_xfer_partial " Pedro Alves
2014-01-08 15:29 ` Yao Qi
2014-01-14 14:31 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389166060-434-1-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).