From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/2] minor cleanups for cmd_list_element
Date: Mon, 13 Jan 2014 16:29:00 -0000 [thread overview]
Message-ID: <1389630533-28327-1-git-send-email-tromey@redhat.com> (raw)
While working on something else, I happened to notice that
cmd_list_element is packed poorly.
This little series first cleans up cmd_list_element by replacing a
flag field with bitfields. I think the resulting code is clearer.
The second patch trivially rearranges cmd_list_element. The savings
are modest -- around 50k for "gdb --batch", the best possible case --
but I don't think there is any downside.
Built and regression tested on x86-64 Fedora 18. I also ran
check-perf and compared the results; the memory use is down a bit and
all the performance differences are just noise.
Tom
next reply other threads:[~2014-01-13 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 16:29 Tom Tromey [this message]
2014-01-13 16:29 ` [PATCH 1/2] convert flags to bitfields Tom Tromey
2014-01-13 16:29 ` [PATCH 2/2] better packing for command struct Tom Tromey
2014-01-20 16:10 ` [PATCH 0/2] minor cleanups for cmd_list_element Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389630533-28327-1-git-send-email-tromey@redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).