From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [FYI 2/3] remove use_windows
Date: Mon, 13 Jan 2014 21:32:00 -0000 [thread overview]
Message-ID: <1389648715-22041-3-git-send-email-tromey@redhat.com> (raw)
In-Reply-To: <1389648715-22041-1-git-send-email-tromey@redhat.com>
Nothing actually uses use_windows, not even Insight. So, this patch
removes it.
2014-01-13 Tom Tromey <tromey@redhat.com>
* defs.h (use_windows): Remove.
* gdb.c (main): Update.
* main.c (captured_main, gdb_main): Update.
* main.h (struct captured_main_args) <use_windows>: Remove.
* top.c (use_windows): Remove.
---
gdb/ChangeLog | 8 ++++++++
gdb/defs.h | 4 ----
gdb/gdb.c | 1 -
gdb/main.c | 13 -------------
gdb/main.h | 1 -
gdb/top.c | 5 -----
6 files changed, 8 insertions(+), 24 deletions(-)
diff --git a/gdb/defs.h b/gdb/defs.h
index 7a7d474..d86f4a9 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -729,10 +729,6 @@ extern void (*deprecated_call_command_hook) (struct cmd_list_element * c,
extern int (*deprecated_ui_load_progress_hook) (const char *section,
unsigned long num);
-/* Inhibit window interface if non-zero. */
-
-extern int use_windows;
-
/* If this definition isn't overridden by the header files, assume
that isatty and fileno exist on this system. */
#ifndef ISATTY
diff --git a/gdb/gdb.c b/gdb/gdb.c
index e708b34..78cfb12 100644
--- a/gdb/gdb.c
+++ b/gdb/gdb.c
@@ -29,7 +29,6 @@ main (int argc, char **argv)
memset (&args, 0, sizeof args);
args.argc = argc;
args.argv = argv;
- args.use_windows = 0;
args.interpreter_p = INTERP_CONSOLE;
return gdb_main (&args);
}
diff --git a/gdb/main.c b/gdb/main.c
index 0c8349e..efb49f5 100644
--- a/gdb/main.c
+++ b/gdb/main.c
@@ -588,19 +588,14 @@ captured_main (void *data)
xfree (interpreter_p);
interpreter_p = xstrdup (INTERP_INSIGHT);
#endif
- use_windows = 1;
break;
case OPT_NOWINDOWS:
/* -nw is equivalent to -i=console. */
xfree (interpreter_p);
interpreter_p = xstrdup (INTERP_CONSOLE);
- use_windows = 0;
break;
case 'f':
annotation_level = 1;
- /* We have probably been invoked from emacs. Disable
- window interface. */
- use_windows = 0;
break;
case 's':
symarg = optarg;
@@ -744,13 +739,6 @@ captured_main (void *data)
}
}
- /* If --help or --version or --configuration, disable window
- interface. */
- if (print_help || print_version || print_configuration)
- {
- use_windows = 0;
- }
-
if (batch_flag)
quiet = 1;
}
@@ -1072,7 +1060,6 @@ captured_main (void *data)
int
gdb_main (struct captured_main_args *args)
{
- use_windows = args->use_windows;
catch_errors (captured_main, args, "", RETURN_MASK_ALL);
/* The only way to end up here is by an error (normal exit is
handled by quit_force()), hence always return an error status. */
diff --git a/gdb/main.h b/gdb/main.h
index cc97bcb..089e1c8 100644
--- a/gdb/main.h
+++ b/gdb/main.h
@@ -24,7 +24,6 @@ struct captured_main_args
{
int argc;
char **argv;
- int use_windows;
const char *interpreter_p;
};
diff --git a/gdb/top.c b/gdb/top.c
index d5ef034..f92043d 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -86,11 +86,6 @@ const char gdbinit[] = GDBINIT;
int inhibit_gdbinit = 0;
-/* If nonzero, and GDB has been configured to be able to use windows,
- attempt to open them upon startup. */
-
-int use_windows = 0;
-
extern char lang_frame_mismatch_warn[]; /* language.c */
/* Flag for whether we want to confirm potentially dangerous
--
1.8.1.4
next prev parent reply other threads:[~2014-01-13 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 21:32 [FYI 0/3] trivial unused fixes Tom Tromey
2014-01-13 21:32 ` [FYI 1/3] remove unused deprecated_flush_hook declaration Tom Tromey
2014-01-13 21:32 ` Tom Tromey [this message]
2014-01-13 21:32 ` [FYI 3/3] remove obsolete declaration Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389648715-22041-3-git-send-email-tromey@redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).