From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80206 invoked by alias); 31 Dec 2018 12:18:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79957 invoked by uid 89); 31 Dec 2018 12:18:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.9 required=5.0 tests=BAYES_00,BODY_8BITS,GARBLED_BODY,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=supplied, HContent-Transfer-Encoding:8bit X-HELO: mail.aegee.org Received: from mail.aegee.org (HELO mail.aegee.org) (144.76.142.78) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 31 Dec 2018 12:18:37 +0000 Authentication-Results: mail.aegee.org/wBVCIWTE031689; auth=pass (PLAIN) smtp.auth=didopalauzov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aegee.org; s=k4096; t=1546258715; i=dkim+MSA-tls@aegee.org; r=y; bh=GO3+rSjckNuutTgzUWuuTA8DG5GOh06bSAIQF64aXzU=; h=Subject:From:To:Date:In-Reply-To:References; b=McMnPHaR1QjaV4T4s8Td6j2wW02XW2TWZu44OKQNZ20WA08/6N1Vn3XCbE7FxNW1k IYy87Zz4ZoSJIynNWlcQw4T/o8qBICy3NSXOta70p9lSfvkBmgWLUvzTbzkw9s6Q/u TVGUuxEsPkXDXMjIxV+1/EhScPnhnmyaIcs6xYsclSR2U0ZJ/lC1LfAY5CSF11Dj4h XqgcrBoxBG48MletZiig8A1RQ+UK+22Li+czNC+pcD79KHJ2lWCLtx1cLGuqps66rY Z8iaPtYh4nCfMsxDPIzqDDm2AotCyDDzSJ1zOw5fjqDVYFP9DYyJ+XNYdOTh0sbCuB vnti6cJipsxKhzX4wX+8xVeP5E47oNLJ0dd+Nd6xIZFiYqIrr6Z2sC43/cKwqpPpES +XmC+mIfKu/WGowQmLdf5ZihL81N39Xuzbxqtw9FGYd5JEQnYnLX7xYvT7LjzSG7kB viZU+/jNa+K1gTJI9+gyyjdV/M8PZWvf9+RvDNjd8AQ3ErUbBbmUPFoiK9sDb9tR3h s4aTpiUKgJpR1J/VY50P2C0TjKPJzb9GMp14NSSjJsozPidIPc7RNL5oXQ+X7Vz9Mp WauZQKKxfLK7Zq8xZCwY7CAK3yFzO/mqeO8vMvfA0H3Ly4WgwNXPuEJ58zOWvA05Vn isSDDxfNhMaDCaA8NBJFB6ks= Authentication-Results: mail.aegee.org/wBVCIWTE031689; dkim=none Received: from Tylan (HSI-KBW-085-216-002-055.hsi.kabelbw.de [85.216.2.55]) (authenticated bits=0) by mail.aegee.org (8.15.2/8.15.2) with ESMTPSA id wBVCIWTE031689 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 31 Dec 2018 12:18:33 GMT Message-ID: <1391dd6b6b8376612ad5eb6740312a7d9a69c91a.camel@aegee.org> Subject: +reminder+ Don't build readline/libreadline.a, when --with-system-readline is supplied From: =?UTF-8?Q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD_?= =?UTF-8?Q?=D0=9F=D0=B0=D0=BB=D0=B0=D1=83=D0=B7=D0=BE=D0=B2?= To: gdb-patches@sourceware.org Date: Mon, 31 Dec 2018 12:18:00 -0000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.31.4 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00448.txt.bz2 On Wed, 2018-12-12 at 07:46 +0000, Дилян Палаузов wrote: > https://sourceware.org/bugzilla/show_bug.cgi?id=18632 > > The bundled libreadline is always built, even if the system is > ./configure'd --with-system-readline and the build libreadline.a is not > used. > > Proposed patch: > > Fix ./configure.ac not to proceed readline/, when --with-system- > readline is provided > > diff --git a/configure.ac b/configure.ac > index 159f968..adf6dfb 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then > noconfigdirs="$noconfigdirs zlib" > fi > > +# Don't compile the bundled readline/libreadline.a if --with-system- > readline > +# is provided. > +if test x$with_system_readline = xyes ; then > + noconfigdirs="$noconfigdirs readline" > +fi > + > # some tools are so dependent upon X11 that if we're not building with > X, > # it's not even worth trying to configure, much less build, that tool.