public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [FYI] mark *_varobj_ops as "extern"
@ 2014-02-20 21:13 Tom Tromey
  0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2014-02-20 21:13 UTC (permalink / raw)
  To: gdb-patches; +Cc: Tom Tromey

The AIX linker pointed out that gdb had multiple definitions of the
various *_varobj_ops objects.  This patch fixes the problem by marking
the declarations as "extern" in varobj.h.  Tested by rebuilding on
x86-64 Fedora 18 and on AIX.

2014-02-20  Tom Tromey  <tromey@redhat.com>

	* varobj.h (c_varobj_ops, cplus_varobj_ops, java_varobj_ops)
	(ada_varobj_ops): Mark "extern".
---
 gdb/ChangeLog | 5 +++++
 gdb/varobj.h  | 8 ++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/gdb/varobj.h b/gdb/varobj.h
index e4007bf..1199e0b 100644
--- a/gdb/varobj.h
+++ b/gdb/varobj.h
@@ -215,10 +215,10 @@ struct lang_varobj_ops
 			    struct type *new_type);
 };
 
-const struct lang_varobj_ops c_varobj_ops;
-const struct lang_varobj_ops cplus_varobj_ops;
-const struct lang_varobj_ops java_varobj_ops;
-const struct lang_varobj_ops ada_varobj_ops;
+extern const struct lang_varobj_ops c_varobj_ops;
+extern const struct lang_varobj_ops cplus_varobj_ops;
+extern const struct lang_varobj_ops java_varobj_ops;
+extern const struct lang_varobj_ops ada_varobj_ops;
 
 #define default_varobj_ops c_varobj_ops
 /* API functions */
-- 
1.8.1.4

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-02-20 21:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-20 21:13 [FYI] mark *_varobj_ops as "extern" Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).