From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7451D3894C1D for ; Wed, 7 Apr 2021 01:45:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7451D3894C1D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1371jnck030065 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 6 Apr 2021 21:45:54 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1371jnck030065 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CB57B1E789 for ; Tue, 6 Apr 2021 21:45:49 -0400 (EDT) Subject: Re: [PATCH] sim/m32c: fix memory leaks in opc2c To: gdb-patches@sourceware.org References: <20210405145856.3925296-1-simon.marchi@polymtl.ca> From: Simon Marchi Message-ID: <13aff427-e308-33cb-0aed-4b4285c52df6@polymtl.ca> Date: Tue, 6 Apr 2021 21:45:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 7 Apr 2021 01:45:49 +0000 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Apr 2021 01:45:57 -0000 > i'm not keen on pushing it in this direction exactly. it would mean every > caller would have to update & keep track. > > i think you could define an IGEN variable in common/Make-common.in and change > all callers over to that. then that would be the only place you'd have to add > any sanitizer related variables to. > -mike > I can do that, but I'm not sure where in common/Make-common.in I should add the variable. There seems to be a logic to the organization in that file, but I don't get it. Also, not that ppc has its own igen, so I guess it will still use its own definition. Another option is to just factor out the env var: DISABLE_LSAN = ASAN_OPTIONS=detect_leaks=0 ... and still use it in rules: target: source $(DISABLE_LSAN) ../igen/igen --blah Worst case, if somebody forgets to use DISABLE_LSAN somewhere, someone building with ASan will notice and it's a trivial fix to add it. Anyway, feel free to push the version you prefer, it will be faster than telling me how to do it :). Side-note, I saw some `@GMAKE_TRUE@` in Make-common.in. In GDB, we decided to require GNU make and remove that complexity, in case you want to do the same. Simon