From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 96A803858405 for ; Fri, 22 Jul 2022 19:43:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96A803858405 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 26MJh5ST026293 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Jul 2022 15:43:09 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 26MJh5ST026293 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1D9201E222; Fri, 22 Jul 2022 15:43:05 -0400 (EDT) Message-ID: <13cfa5f0-b83b-5cdf-3590-eb11036e5072@polymtl.ca> Date: Fri, 22 Jul 2022 15:43:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] gdb/testsuite: give binaries distinct names in Ada tests Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches References: <20220719171417.3651000-1-simon.marchi@polymtl.ca> <87czdxj6u7.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87czdxj6u7.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 22 Jul 2022 19:43:05 +0000 X-Spam-Status: No, score=-3032.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2022 19:43:12 -0000 On 2022-07-22 15:16, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> Some Ada tests repeat their test sequence with different gnat-encodings, > Simon> typically "all" and "minimal". However, they give the same name to both > Simon> binaries, meaning the second run overwrites the binary of the first run. > Simon> This makes it difficult and confusing when trying to reproduce problems > Simon> manually with the test artifacts. Change those tests to use unique > Simon> names for each pass. > > Seems like a good idea. Thank you for doing this. > > Tom Thanks, pushed. Simon