From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by sourceware.org (Postfix) with ESMTPS id 1619B3858D38 for ; Tue, 17 Oct 2023 09:07:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1619B3858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1619B3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697533637; cv=none; b=FzHzDYre045sp0H2mHaeqkB9GM4ZYOEkUSOOrrG0UzG3MU2MjP09mcldzS3S9li63fgE+C649si1LEFn5xtlb7lEUUmAPBCHDNTUEbxy5MwVq8zDSnQcOlYHmMbACtYre1HLjx309O818xXwwTLX28b2gJmZv8D0yNxwPuT2YHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697533637; c=relaxed/simple; bh=hxGgN7+1gn5nxPTW30ojVO0IwORO6VrYO5TBExra5vE=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=D29JUzeAhIGaaTfgUgYaD35d6B3+EtrSIgMew00JyBznd4aSJILqEnkJXA2fk0qv+mMxblyjZjRTuAfHWBTufpf91ktL6RJnLvPAHvPWRzLtRfMCS9B600dgWdXlwq1tK3ghQ7pAVH8WrbjrCzpLTn2bGI19nW2CjYdD6FQ3eBk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-32daeed7771so2014224f8f.3 for ; Tue, 17 Oct 2023 02:07:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697533635; x=1698138435; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qZnZOXb9tF2izqdIYp2HrjY4hDBz/qSI8yBnbFaSrBE=; b=X2lGWtsyOuoXcsjPhUNkJ+yNZnasbRGrn+ZF/AMI68A4IXOQArwjQvOYL9e9nHTgdN 7Ay1IMANg89XDEp4OjjpE2POWAd0OXsxE1MikvnL79Ky4KDkNS3EpGRZAUQS5X8PTU0M ozUTXsdGcitdKmpg9cK73+zmpepLqN9quOiYEvs+sol1hk5/PCyy5T8u17+1hq6Z1XQO JC7XIsrQa+Dc9Z3m3eptpe3+5mABFwTFUcU4xPIhavv07Byprk4fYqk4dJjlWyw40GVn XS6RoxeraOOIS78lLqYvAPVruRYHbvUut3YvO+5w8g1iQE0FM68lNHwDtjkvFvT1h/cT GM3w== X-Gm-Message-State: AOJu0YybbMBCU6PzO7QCMGUGhol/mwQbW9yPCYvyoZMIyOFvgrgA63sf M/bhDvfR0nD6NuYCnryhqZQMoi8u0RVWPA== X-Google-Smtp-Source: AGHT+IGgx9DIyxBIjHmILaBs/YyabUWWDg8JNltza9GeYPQtf+xMH1JZHk6ivZRFJMVFMVmgL1TUQg== X-Received: by 2002:a05:6000:1375:b0:32d:a98c:aa1f with SMTP id q21-20020a056000137500b0032da98caa1fmr1370161wrz.1.1697533634537; Tue, 17 Oct 2023 02:07:14 -0700 (PDT) Received: from ?IPV6:2001:8a0:f939:d200:5aaf:ade2:476b:3ff2? ([2001:8a0:f939:d200:5aaf:ade2:476b:3ff2]) by smtp.gmail.com with ESMTPSA id dd8-20020a0560001e8800b0032d9efeccd8sm1225266wrb.51.2023.10.17.02.07.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 02:07:14 -0700 (PDT) Message-ID: <13d8b3d7-f1e5-41ad-b1dc-d1be245158c6@palves.net> Date: Tue, 17 Oct 2023 10:06:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] More C++17 Updates Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20231016230527.1820819-1-tom@tromey.com> From: Pedro Alves In-Reply-To: <20231016230527.1820819-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-17 00:02, Tom Tromey wrote: > This series is based on Lancelot's C++17 series. I found some more > spots in gdb that could easily take advantage of C++17. > > I'm sure there are some more spots to be found. For example, I > suspect try_embed can be used in more places than the one that was > commented as such. I guess you mean try_emplace. > > I have another branch where I try to replace gdb::array_view with a > C++20-compatible std::span. However, this one is a bit more invasive, > so I thought I would leave it for a little later. I wish that C++ had went the array_view route, but oh well. > Note that gdb > doesn't currently build cleanly in C++20 mode (mostly but IIRC not > entirely due to the use of 'volatile' in the Guile headers). > > Regression tested on x86-64 Fedora 38. > > Let me know what you think. Other than the comment on the try_emplace patch, this all LGTM: Approved-By: Pedro Alves