* [PATCH v2] Fix mi_expect_stop for non-zero exit codes
@ 2014-05-13 21:14 Simon Marchi
2014-05-15 18:39 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2014-05-13 21:14 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
This patch was accepted almost a year ago, but I only recently received my
commit access. I submit it again to make sure it is still relevant.
Original submission: https://sourceware.org/ml/gdb-patches/2013-06/msg00736.html
The message displayed by gdb is different when the inferior exits with
zero and non-zero values, this fix takes that into account.
gdb/testsuite/ChangeLog:
2014-05-13 Simon Marchi <simon.marchi@ericsson.com>
* lib/mi-support.exp (mi_expect_stop): Expect message for
inferiors that exit with non-zero exit code.
---
gdb/testsuite/lib/mi-support.exp | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp
index ad58775..4478ba0 100644
--- a/gdb/testsuite/lib/mi-support.exp
+++ b/gdb/testsuite/lib/mi-support.exp
@@ -1068,6 +1068,20 @@ proc mi_expect_stop { reason func args file line extra test } {
}
return
}
+ if { $reason == "exited" } {
+ gdb_expect {
+ -re "\\*stopped,reason=\"exited\",exit-code=\"\[0-7\]+\"\r\n$prompt_re" {
+ pass "$test"
+ }
+ -re ".*$mi_gdb_prompt$" {
+ fail "$test (inferior not stopped)"
+ }
+ timeout {
+ fail "$test (unknown output after running)"
+ }
+ }
+ return
+ }
if { $reason == "solib-event" } {
set pattern "\\*stopped,reason=\"solib-event\",thread-id=\"$decimal\",stopped-threads=$any\r\n($thread_selected_re|$breakpoint_re)*$prompt_re"
--
2.0.0.rc0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Fix mi_expect_stop for non-zero exit codes
2014-05-13 21:14 [PATCH v2] Fix mi_expect_stop for non-zero exit codes Simon Marchi
@ 2014-05-15 18:39 ` Tom Tromey
2014-05-15 19:44 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2014-05-15 18:39 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
Simon> This patch was accepted almost a year ago, but I only recently
Simon> received my commit access. I submit it again to make sure it is
Simon> still relevant.
Simon> Original submission: https://sourceware.org/ml/gdb-patches/2013-06/msg00736.html
Thanks for linking to the original.
Simon> 2014-05-13 Simon Marchi <simon.marchi@ericsson.com>
Simon> * lib/mi-support.exp (mi_expect_stop): Expect message for
Simon> inferiors that exit with non-zero exit code.
Still ok. Thanks!
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Fix mi_expect_stop for non-zero exit codes
2014-05-15 18:39 ` Tom Tromey
@ 2014-05-15 19:44 ` Simon Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2014-05-15 19:44 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On 14-05-15 02:39 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>
> Simon> This patch was accepted almost a year ago, but I only recently
> Simon> received my commit access. I submit it again to make sure it is
> Simon> still relevant.
>
> Simon> Original submission: https://sourceware.org/ml/gdb-patches/2013-06/msg00736.html
>
> Thanks for linking to the original.
>
> Simon> 2014-05-13 Simon Marchi <simon.marchi@ericsson.com>
>
> Simon> * lib/mi-support.exp (mi_expect_stop): Expect message for
> Simon> inferiors that exit with non-zero exit code.
>
> Still ok. Thanks!
>
> Tom
>
Pushed, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-15 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-13 21:14 [PATCH v2] Fix mi_expect_stop for non-zero exit codes Simon Marchi
2014-05-15 18:39 ` Tom Tromey
2014-05-15 19:44 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).