From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 03/11] AARCH64: Replace regset_alloc() invocations by static regset structures.
Date: Thu, 15 May 2014 15:49:00 -0000 [thread overview]
Message-ID: <1400168975-3145-4-git-send-email-arnez@linux.vnet.ibm.com> (raw)
In-Reply-To: <1400168975-3145-1-git-send-email-arnez@linux.vnet.ibm.com>
After removal of the regset_alloc invocations, the tdep fields
'gregset' and 'fpregset' become obsolete and are thus removed.
gdb/
* aarch64-linux-tdep.c (aarch64_linux_gregset)
(aarch64_linux_fpregset): New static regset structures.
(aarch64_linux_regset_from_core_section): Drop dynamic allocation
of regset structures.
* aarch64-tdep.h (struct gdbarch_tdep): Remove 'gregset' and
'fpregset' fields.
---
gdb/aarch64-linux-tdep.c | 29 +++++++++++++++--------------
gdb/aarch64-tdep.h | 4 ----
2 files changed, 15 insertions(+), 18 deletions(-)
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index 92d1248..6f52c8c 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -240,6 +240,18 @@ supply_fpregset_from_core (const struct regset *regset,
aarch64_linux_supply_fpregset (regcache, (const gdb_byte *) regbuf);
}
+/* Register set definitions. */
+
+static const struct regset aarch64_linux_gregset =
+ {
+ NULL, supply_gregset_from_core, NULL
+ };
+
+static const struct regset aarch64_linux_fpregset =
+ {
+ NULL, supply_fpregset_from_core, NULL
+ };
+
/* Implement the "regset_from_core_section" gdbarch method. */
static const struct regset *
@@ -247,25 +259,14 @@ aarch64_linux_regset_from_core_section (struct gdbarch *gdbarch,
const char *sect_name,
size_t sect_size)
{
- struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
-
if (strcmp (sect_name, ".reg") == 0
&& sect_size == AARCH64_LINUX_SIZEOF_GREGSET)
- {
- if (tdep->gregset == NULL)
- tdep->gregset = regset_alloc (gdbarch, supply_gregset_from_core,
- NULL);
- return tdep->gregset;
- }
+ return &aarch64_linux_gregset;
if (strcmp (sect_name, ".reg2") == 0
&& sect_size == AARCH64_LINUX_SIZEOF_FPREGSET)
- {
- if (tdep->fpregset == NULL)
- tdep->fpregset = regset_alloc (gdbarch, supply_fpregset_from_core,
- NULL);
- return tdep->fpregset;
- }
+ return &aarch64_linux_fpregset;
+
return NULL;
}
diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
index 30a5ee3..78fb779 100644
--- a/gdb/aarch64-tdep.h
+++ b/gdb/aarch64-tdep.h
@@ -82,10 +82,6 @@ struct gdbarch_tdep
/* And the size of each entry in the buf. */
size_t jb_elt_size;
- /* Cached core file helpers. */
- struct regset *gregset;
- struct regset *fpregset;
-
/* Types for AdvSISD registers. */
struct type *vnq_type;
struct type *vnd_type;
--
1.8.4.2
next prev parent reply other threads:[~2014-05-15 15:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 15:49 [PATCH 00/11] Regset rework preparations part 1 Andreas Arnez
2014-05-15 15:49 ` [PATCH 02/11] Remove 'arch' field from regset structure Andreas Arnez
2014-05-15 15:49 ` [PATCH 09/11] SPARC: Rename register maps from "*regset" to "*regmap" Andreas Arnez
2014-05-15 15:49 ` Andreas Arnez [this message]
2014-05-15 15:49 ` [PATCH 06/11] MIPS: Replace regset_alloc() invocations by static regset structures Andreas Arnez
2014-05-15 15:49 ` [PATCH 08/11] SCORE: Replace regset_alloc() invocation by a static regset structure Andreas Arnez
2014-05-15 15:49 ` [PATCH 04/11] ARM: Replace regset_alloc() invocations by static regset structures Andreas Arnez
2014-05-15 15:49 ` [PATCH 10/11] SPARC: " Andreas Arnez
2014-05-15 15:49 ` [PATCH 05/11] X86: " Andreas Arnez
2014-05-15 15:49 ` [PATCH 11/11] Drop regset_alloc() Andreas Arnez
2014-05-15 15:50 ` [PATCH 01/11] Constify regset structures Andreas Arnez
2014-05-15 15:59 ` [PATCH 07/11] MN10300: Replace regset_alloc() invocations by static " Andreas Arnez
2014-05-19 7:32 ` [PING] [PATCH 00/11] Regset rework preparations part 1 Andreas Arnez
2014-05-20 20:41 ` Maciej W. Rozycki
2014-05-21 10:39 ` Pedro Alves
2014-05-22 7:28 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400168975-3145-4-git-send-email-arnez@linux.vnet.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).