From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 04/11] ARM: Replace regset_alloc() invocations by static regset structures.
Date: Thu, 15 May 2014 15:49:00 -0000 [thread overview]
Message-ID: <1400168975-3145-5-git-send-email-arnez@linux.vnet.ibm.com> (raw)
In-Reply-To: <1400168975-3145-1-git-send-email-arnez@linux.vnet.ibm.com>
After removal of the regset_alloc invocations, the appropriate tdep
fields become obsolete and are thus removed.
gdb/
* arm-linux-tdep.c (arm_linux_gregset, arm_linux_fpregset)
(arm_linux_vfpregset): New static regset structures.
(arm_linux_regset_from_core_section): Remove dynamic allocation of
regset structures.
* arm-tdep.h (struct gdbarch_tdep): Remove 'gregset', 'fpregset',
and 'vfpregset' fields.
---
gdb/arm-linux-tdep.c | 38 ++++++++++++++++++--------------------
gdb/arm-tdep.h | 3 ---
2 files changed, 18 insertions(+), 23 deletions(-)
diff --git a/gdb/arm-linux-tdep.c b/gdb/arm-linux-tdep.c
index 98b912b..028a95b 100644
--- a/gdb/arm-linux-tdep.c
+++ b/gdb/arm-linux-tdep.c
@@ -686,6 +686,21 @@ arm_linux_collect_vfp (const struct regset *regset,
regs + (regno - ARM_D0_REGNUM) * 8);
}
+static const struct regset arm_linux_gregset =
+ {
+ NULL, arm_linux_supply_gregset, arm_linux_collect_gregset
+ };
+
+static const struct regset arm_linux_fpregset =
+ {
+ NULL, arm_linux_supply_nwfpe, arm_linux_collect_nwfpe
+ };
+
+static const struct regset arm_linux_vfpregset =
+ {
+ NULL, arm_linux_supply_vfp, arm_linux_collect_vfp
+ };
+
/* Return the appropriate register set for the core section identified
by SECT_NAME and SECT_SIZE. */
@@ -693,34 +708,17 @@ static const struct regset *
arm_linux_regset_from_core_section (struct gdbarch *gdbarch,
const char *sect_name, size_t sect_size)
{
- struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
-
if (strcmp (sect_name, ".reg") == 0
&& sect_size == ARM_LINUX_SIZEOF_GREGSET)
- {
- if (tdep->gregset == NULL)
- tdep->gregset = regset_alloc (gdbarch, arm_linux_supply_gregset,
- arm_linux_collect_gregset);
- return tdep->gregset;
- }
+ return &arm_linux_gregset;
if (strcmp (sect_name, ".reg2") == 0
&& sect_size == ARM_LINUX_SIZEOF_NWFPE)
- {
- if (tdep->fpregset == NULL)
- tdep->fpregset = regset_alloc (gdbarch, arm_linux_supply_nwfpe,
- arm_linux_collect_nwfpe);
- return tdep->fpregset;
- }
+ return &arm_linux_fpregset;
if (strcmp (sect_name, ".reg-arm-vfp") == 0
&& sect_size == ARM_LINUX_SIZEOF_VFP)
- {
- if (tdep->vfpregset == NULL)
- tdep->vfpregset = regset_alloc (gdbarch, arm_linux_supply_vfp,
- arm_linux_collect_vfp);
- return tdep->vfpregset;
- }
+ return &arm_linux_vfpregset;
return NULL;
}
diff --git a/gdb/arm-tdep.h b/gdb/arm-tdep.h
index f8ba122..29669d0 100644
--- a/gdb/arm-tdep.h
+++ b/gdb/arm-tdep.h
@@ -193,9 +193,6 @@ struct gdbarch_tdep
/* Convention for returning structures. */
enum struct_return struct_return;
- /* Cached core file helpers. */
- struct regset *gregset, *fpregset, *vfpregset;
-
/* ISA-specific data types. */
struct type *arm_ext_type;
struct type *neon_double_type;
--
1.8.4.2
next prev parent reply other threads:[~2014-05-15 15:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 15:49 [PATCH 00/11] Regset rework preparations part 1 Andreas Arnez
2014-05-15 15:49 ` [PATCH 09/11] SPARC: Rename register maps from "*regset" to "*regmap" Andreas Arnez
2014-05-15 15:49 ` [PATCH 05/11] X86: Replace regset_alloc() invocations by static regset structures Andreas Arnez
2014-05-15 15:49 ` Andreas Arnez [this message]
2014-05-15 15:49 ` [PATCH 11/11] Drop regset_alloc() Andreas Arnez
2014-05-15 15:49 ` [PATCH 03/11] AARCH64: Replace regset_alloc() invocations by static regset structures Andreas Arnez
2014-05-15 15:49 ` [PATCH 10/11] SPARC: " Andreas Arnez
2014-05-15 15:49 ` [PATCH 06/11] MIPS: " Andreas Arnez
2014-05-15 15:49 ` [PATCH 08/11] SCORE: Replace regset_alloc() invocation by a static regset structure Andreas Arnez
2014-05-15 15:49 ` [PATCH 02/11] Remove 'arch' field from " Andreas Arnez
2014-05-15 15:50 ` [PATCH 01/11] Constify regset structures Andreas Arnez
2014-05-15 15:59 ` [PATCH 07/11] MN10300: Replace regset_alloc() invocations by static " Andreas Arnez
2014-05-19 7:32 ` [PING] [PATCH 00/11] Regset rework preparations part 1 Andreas Arnez
2014-05-20 20:41 ` Maciej W. Rozycki
2014-05-21 10:39 ` Pedro Alves
2014-05-22 7:28 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400168975-3145-5-git-send-email-arnez@linux.vnet.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).