From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 08/11] SCORE: Replace regset_alloc() invocation by a static regset structure.
Date: Thu, 15 May 2014 15:49:00 -0000 [thread overview]
Message-ID: <1400168975-3145-9-git-send-email-arnez@linux.vnet.ibm.com> (raw)
In-Reply-To: <1400168975-3145-1-git-send-email-arnez@linux.vnet.ibm.com>
Since this changes makes the only member of the tdep structure
obsolete, the tdep structure is removed.
gdb/
* score-tdep.c (score7_linux_gregset): New static regset
structure.
(score7_linux_regset_from_core_section): Remove dynamic regset
allocation.
(score_gdbarch_init): Drop allocation of tdep structure.
* score-tdep.h (struct gdbarch_tdep): Remove declaration.
---
gdb/score-tdep.c | 21 ++++++++-------------
gdb/score-tdep.h | 7 -------
2 files changed, 8 insertions(+), 20 deletions(-)
diff --git a/gdb/score-tdep.c b/gdb/score-tdep.c
index 078315a..c224189 100644
--- a/gdb/score-tdep.c
+++ b/gdb/score-tdep.c
@@ -1447,6 +1447,12 @@ score7_linux_supply_gregset(const struct regset *regset,
}
}
+static const struct regset score7_linux_gregset =
+ {
+ NULL,
+ score7_linux_supply_gregset, NULL
+ };
+
/* Return the appropriate register set from the core section identified
by SECT_NAME and SECT_SIZE. */
@@ -1454,20 +1460,11 @@ static const struct regset *
score7_linux_regset_from_core_section(struct gdbarch *gdbarch,
const char *sect_name, size_t sect_size)
{
- struct gdbarch_tdep *tdep;
-
gdb_assert (gdbarch != NULL);
gdb_assert (sect_name != NULL);
- tdep = gdbarch_tdep (gdbarch);
-
if (strcmp(sect_name, ".reg") == 0 && sect_size == sizeof(elf_gregset_t))
- {
- if (tdep->gregset == NULL)
- tdep->gregset = regset_alloc (gdbarch,
- score7_linux_supply_gregset, NULL);
- return tdep->gregset;
- }
+ return &score7_linux_gregset;
return NULL;
}
@@ -1476,7 +1473,6 @@ static struct gdbarch *
score_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
{
struct gdbarch *gdbarch;
- struct gdbarch_tdep *tdep;
target_mach = info.bfd_arch_info->mach;
arches = gdbarch_list_lookup_by_info (arches, &info);
@@ -1484,8 +1480,7 @@ score_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
{
return (arches->gdbarch);
}
- tdep = xcalloc(1, sizeof(struct gdbarch_tdep));
- gdbarch = gdbarch_alloc (&info, tdep);
+ gdbarch = gdbarch_alloc (&info, NULL);
set_gdbarch_short_bit (gdbarch, 16);
set_gdbarch_int_bit (gdbarch, 32);
diff --git a/gdb/score-tdep.h b/gdb/score-tdep.h
index b34f5a9..02a334e 100644
--- a/gdb/score-tdep.h
+++ b/gdb/score-tdep.h
@@ -49,13 +49,6 @@ enum gdb_regnum
/* Forward declarations. */
struct regset;
-/* Target-dependent structure in gdbarch */
-struct gdbarch_tdep
-{
- /* Cached core file helpers. */
- struct regset *gregset;
-};
-
/* Linux Core file support (dirty hack)
S+core Linux register set definition, copy from S+core Linux. */
--
1.8.4.2
next prev parent reply other threads:[~2014-05-15 15:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 15:49 [PATCH 00/11] Regset rework preparations part 1 Andreas Arnez
2014-05-15 15:49 ` [PATCH 11/11] Drop regset_alloc() Andreas Arnez
2014-05-15 15:49 ` [PATCH 05/11] X86: Replace regset_alloc() invocations by static regset structures Andreas Arnez
2014-05-15 15:49 ` [PATCH 10/11] SPARC: " Andreas Arnez
2014-05-15 15:49 ` Andreas Arnez [this message]
2014-05-15 15:49 ` [PATCH 04/11] ARM: " Andreas Arnez
2014-05-15 15:49 ` [PATCH 06/11] MIPS: " Andreas Arnez
2014-05-15 15:49 ` [PATCH 03/11] AARCH64: " Andreas Arnez
2014-05-15 15:49 ` [PATCH 09/11] SPARC: Rename register maps from "*regset" to "*regmap" Andreas Arnez
2014-05-15 15:49 ` [PATCH 02/11] Remove 'arch' field from regset structure Andreas Arnez
2014-05-15 15:50 ` [PATCH 01/11] Constify regset structures Andreas Arnez
2014-05-15 15:59 ` [PATCH 07/11] MN10300: Replace regset_alloc() invocations by static " Andreas Arnez
2014-05-19 7:32 ` [PING] [PATCH 00/11] Regset rework preparations part 1 Andreas Arnez
2014-05-20 20:41 ` Maciej W. Rozycki
2014-05-21 10:39 ` Pedro Alves
2014-05-22 7:28 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400168975-3145-9-git-send-email-arnez@linux.vnet.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).