From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Phil Muldoon <pmuldoon@redhat.com>
Subject: [PATCH 05/14] change how the CLI handles comments
Date: Fri, 16 May 2014 15:41:00 -0000 [thread overview]
Message-ID: <1400253995-12333-6-git-send-email-tromey@redhat.com> (raw)
In-Reply-To: <1400253995-12333-1-git-send-email-tromey@redhat.com>
From: Phil Muldoon <pmuldoon@redhat.com>
When using the multi-line feature, we don't want the gdb CLI to remove
comments from the command list, as this will remove things like
"#define".
This patch moves the comment feature into command_loop to avoid this
problem.
2014-05-16 Phil Muldoon <pmuldoon@redhat.com>
* top.c (command_loop): Handle comments here...
(command_line_input): ... not here.
---
gdb/ChangeLog | 5 +++++
gdb/top.c | 20 +++++++-------------
2 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/gdb/top.c b/gdb/top.c
index fa20025..16694e6 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -560,11 +560,14 @@ command_loop (void)
make_command_stats_cleanup (1);
- execute_command (command, instream == stdin);
-
- /* Do any commands attached to breakpoint we are stopped at. */
- bpstat_do_actions ();
+ /* Do not execute commented lines. */
+ if (command[0] != '#')
+ {
+ execute_command (command, instream == stdin);
+ /* Do any commands attached to breakpoint we are stopped at. */
+ bpstat_do_actions ();
+ }
do_cleanups (old_chain);
}
}
@@ -1057,15 +1060,6 @@ command_line_input (char *prompt_arg, int repeat, char *annotation_suffix)
if (*linebuffer && input_from_terminal_p ())
add_history (linebuffer);
- /* Note: lines consisting solely of comments are added to the command
- history. This is useful when you type a command, and then
- realize you don't want to execute it quite yet. You can comment
- out the command and then later fetch it from the value history
- and remove the '#'. The kill ring is probably better, but some
- people are in the habit of commenting things out. */
- if (*p1 == '#')
- *p1 = '\0'; /* Found a comment. */
-
/* Save into global buffer if appropriate. */
if (repeat)
{
--
1.9.0
next prev parent reply other threads:[~2014-05-16 15:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 15:26 [PATCH 00/14] let gdb reuse gcc's C compiler Tom Tromey
2014-05-16 15:26 ` [PATCH 03/14] add some missing ops to DWARF assembler Tom Tromey
2014-05-16 15:26 ` [PATCH 10/14] make dwarf_expr_frame_base_1 public Tom Tromey
2014-05-16 15:26 ` [PATCH 02/14] add gcc/gdb interface files Tom Tromey
2014-05-19 8:06 ` Yao Qi
2014-05-19 13:53 ` Tom Tromey
2014-05-16 15:26 ` [PATCH 01/14] introduce ui_file_write_for_put Tom Tromey
2014-05-16 15:26 ` [PATCH 08/14] introduce call_function_by_hand_dummy Tom Tromey
2014-05-16 15:26 ` [PATCH 07/14] add infcall_mmap and gcc_target_options gdbarch methods Tom Tromey
2014-05-19 6:13 ` Yao Qi
2014-05-19 6:41 ` Jan Kratochvil
2014-05-19 6:47 ` Jan Kratochvil
2014-05-19 7:42 ` Yao Qi
2014-05-19 8:26 ` Agovic, Sanimir
2014-05-19 11:15 ` Jan Kratochvil
2014-05-16 15:27 ` [PATCH 14/14] the "compile" command Tom Tromey
2014-06-16 9:55 ` (Doc ping [for news and manual]) -- " Phil Muldoon
2014-06-16 15:25 ` Eli Zaretskii
2014-06-20 9:17 ` Phil Muldoon
2014-06-20 9:42 ` Eli Zaretskii
2014-06-20 10:01 ` Phil Muldoon
2014-06-20 12:37 ` Eli Zaretskii
2014-06-20 14:42 ` Tom Tromey
2014-06-20 19:00 ` Eli Zaretskii
2014-06-21 7:32 ` Eli Zaretskii
2014-05-16 15:41 ` Tom Tromey [this message]
2014-05-18 23:26 ` [PATCH 05/14] change how the CLI handles comments Doug Evans
2014-05-19 14:07 ` Phil Muldoon
2014-06-03 7:04 ` Doug Evans
2014-05-16 15:43 ` [PATCH 12/14] add linux_infcall_mmap Tom Tromey
2014-05-16 15:43 ` [PATCH 13/14] add s390_gcc_target_options Tom Tromey
2014-05-16 15:43 ` [PATCH 09/14] split dwarf2_fetch_cfa_info from dwarf2_compile_expr_to_ax Tom Tromey
2014-05-16 15:56 ` [PATCH 04/14] add make_unqualified_type Tom Tromey
2014-05-16 16:18 ` [PATCH 06/14] add dummy frame destructor Tom Tromey
2014-05-16 16:18 ` [PATCH 11/14] export dwarf2_reg_to_regnum_or_error Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400253995-12333-6-git-send-email-tromey@redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).