From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: [PATCH 07/14] add infcall_mmap and gcc_target_options gdbarch methods
Date: Fri, 16 May 2014 15:26:00 -0000 [thread overview]
Message-ID: <1400253995-12333-8-git-send-email-tromey@redhat.com> (raw)
In-Reply-To: <1400253995-12333-1-git-send-email-tromey@redhat.com>
From: Jan Kratochvil <jan.kratochvil@redhat.com>
The compiler needed two new gdbarch methods.
The infcall_mmap method allocates memory in the inferior.
This is used when inserting the object code.
The gcc_target_options method computes some arch-specific gcc options
to pass to the compiler. This is used to ensure that gcc generates
object code for the correct architecture.
2014-05-16 Jan Kratochvil <jan.kratochvil@redhat.com>
* arch-utils.c (default_infcall_mmap)
(default_gcc_target_options): New functions.
* arch-utils.h (default_infcall_mmap, default_gcc_target_options):
Declare.
* gdbarch.h: Rebuild.
* gdbarch.c: Rebuild.
* gdbarch.sh (infcall_mmap, gcc_target_options): New methods.
---
gdb/ChangeLog | 10 ++++++++++
gdb/arch-utils.c | 13 +++++++++++++
gdb/arch-utils.h | 4 ++++
gdb/gdbarch.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
gdb/gdbarch.h | 18 ++++++++++++++++++
gdb/gdbarch.sh | 12 ++++++++++++
6 files changed, 103 insertions(+)
diff --git a/gdb/arch-utils.c b/gdb/arch-utils.c
index bff1a10..e2aea7a 100644
--- a/gdb/arch-utils.c
+++ b/gdb/arch-utils.c
@@ -819,6 +819,19 @@ int default_insn_is_jump (struct gdbarch *gdbarch, CORE_ADDR addr)
return 0;
}
+CORE_ADDR
+default_infcall_mmap (CORE_ADDR size, unsigned prot)
+{
+ error (_("This target does not support inferior memory allocation by mmap."));
+}
+
+char *
+default_gcc_target_options (struct gdbarch *gdbarch)
+{
+ return xstrprintf ("-m%d%s", gdbarch_ptr_bit (gdbarch),
+ gdbarch_ptr_bit (gdbarch) == 64 ? " -mcmodel=large" : "");
+}
+
/* */
/* -Wmissing-prototypes */
diff --git a/gdb/arch-utils.h b/gdb/arch-utils.h
index 46d1573..d4bf353 100644
--- a/gdb/arch-utils.h
+++ b/gdb/arch-utils.h
@@ -174,4 +174,8 @@ extern int default_return_in_first_hidden_param_p (struct gdbarch *,
extern int default_insn_is_call (struct gdbarch *, CORE_ADDR);
extern int default_insn_is_ret (struct gdbarch *, CORE_ADDR);
extern int default_insn_is_jump (struct gdbarch *, CORE_ADDR);
+
+extern CORE_ADDR default_infcall_mmap (CORE_ADDR size, unsigned prot);
+extern char *default_gcc_target_options (struct gdbarch *gdbarch);
+
#endif
diff --git a/gdb/gdbarch.c b/gdb/gdbarch.c
index 4f82095..b931690 100644
--- a/gdb/gdbarch.c
+++ b/gdb/gdbarch.c
@@ -319,6 +319,8 @@ struct gdbarch
gdbarch_insn_is_ret_ftype *insn_is_ret;
gdbarch_insn_is_jump_ftype *insn_is_jump;
gdbarch_auxv_parse_ftype *auxv_parse;
+ gdbarch_infcall_mmap_ftype *infcall_mmap;
+ gdbarch_gcc_target_options_ftype *gcc_target_options;
};
/* Create a new ``struct gdbarch'' based on information provided by
@@ -411,6 +413,8 @@ gdbarch_alloc (const struct gdbarch_info *info,
gdbarch->insn_is_call = default_insn_is_call;
gdbarch->insn_is_ret = default_insn_is_ret;
gdbarch->insn_is_jump = default_insn_is_jump;
+ gdbarch->infcall_mmap = default_infcall_mmap;
+ gdbarch->gcc_target_options = default_gcc_target_options;
/* gdbarch_alloc() */
return gdbarch;
@@ -630,6 +634,8 @@ verify_gdbarch (struct gdbarch *gdbarch)
/* Skip verify of insn_is_ret, invalid_p == 0 */
/* Skip verify of insn_is_jump, invalid_p == 0 */
/* Skip verify of auxv_parse, has predicate. */
+ /* Skip verify of infcall_mmap, invalid_p == 0 */
+ /* Skip verify of gcc_target_options, invalid_p == 0 */
buf = ui_file_xstrdup (log, &length);
make_cleanup (xfree, buf);
if (length > 0)
@@ -894,6 +900,9 @@ gdbarch_dump (struct gdbarch *gdbarch, struct ui_file *file)
"gdbarch_dump: frame_red_zone_size = %s\n",
plongest (gdbarch->frame_red_zone_size));
fprintf_unfiltered (file,
+ "gdbarch_dump: gcc_target_options = <%s>\n",
+ host_address_to_string (gdbarch->gcc_target_options));
+ fprintf_unfiltered (file,
"gdbarch_dump: gdbarch_gcore_bfd_target_p() = %d\n",
gdbarch_gcore_bfd_target_p (gdbarch));
fprintf_unfiltered (file,
@@ -960,6 +969,9 @@ gdbarch_dump (struct gdbarch *gdbarch, struct ui_file *file)
"gdbarch_dump: in_solib_return_trampoline = <%s>\n",
host_address_to_string (gdbarch->in_solib_return_trampoline));
fprintf_unfiltered (file,
+ "gdbarch_dump: infcall_mmap = <%s>\n",
+ host_address_to_string (gdbarch->infcall_mmap));
+ fprintf_unfiltered (file,
"gdbarch_dump: gdbarch_info_proc_p() = %d\n",
gdbarch_info_proc_p (gdbarch));
fprintf_unfiltered (file,
@@ -4406,6 +4418,40 @@ set_gdbarch_auxv_parse (struct gdbarch *gdbarch,
gdbarch->auxv_parse = auxv_parse;
}
+CORE_ADDR
+gdbarch_infcall_mmap (struct gdbarch *gdbarch, CORE_ADDR size, unsigned prot)
+{
+ gdb_assert (gdbarch != NULL);
+ gdb_assert (gdbarch->infcall_mmap != NULL);
+ if (gdbarch_debug >= 2)
+ fprintf_unfiltered (gdb_stdlog, "gdbarch_infcall_mmap called\n");
+ return gdbarch->infcall_mmap (size, prot);
+}
+
+void
+set_gdbarch_infcall_mmap (struct gdbarch *gdbarch,
+ gdbarch_infcall_mmap_ftype infcall_mmap)
+{
+ gdbarch->infcall_mmap = infcall_mmap;
+}
+
+char *
+gdbarch_gcc_target_options (struct gdbarch *gdbarch)
+{
+ gdb_assert (gdbarch != NULL);
+ gdb_assert (gdbarch->gcc_target_options != NULL);
+ if (gdbarch_debug >= 2)
+ fprintf_unfiltered (gdb_stdlog, "gdbarch_gcc_target_options called\n");
+ return gdbarch->gcc_target_options (gdbarch);
+}
+
+void
+set_gdbarch_gcc_target_options (struct gdbarch *gdbarch,
+ gdbarch_gcc_target_options_ftype gcc_target_options)
+{
+ gdbarch->gcc_target_options = gcc_target_options;
+}
+
/* Keep a registry of per-architecture data-pointers required by GDB
modules. */
diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
index c621091..00fc1ac 100644
--- a/gdb/gdbarch.h
+++ b/gdb/gdbarch.h
@@ -1316,6 +1316,24 @@ typedef int (gdbarch_auxv_parse_ftype) (struct gdbarch *gdbarch, gdb_byte **read
extern int gdbarch_auxv_parse (struct gdbarch *gdbarch, gdb_byte **readptr, gdb_byte *endptr, CORE_ADDR *typep, CORE_ADDR *valp);
extern void set_gdbarch_auxv_parse (struct gdbarch *gdbarch, gdbarch_auxv_parse_ftype *auxv_parse);
+/* Allocate SIZE bytes of PROT protected page aligned memory in inferior.
+ PROT has rwx bitmask format - bit 2 (value 4) is for readable memory, bit 1
+ (value 2) is for writable memory and bit 0 (value 1) is for executable memory.
+ Throw an error if it is not possible. Returned address is always valid. */
+
+typedef CORE_ADDR (gdbarch_infcall_mmap_ftype) (CORE_ADDR size, unsigned prot);
+extern CORE_ADDR gdbarch_infcall_mmap (struct gdbarch *gdbarch, CORE_ADDR size, unsigned prot);
+extern void set_gdbarch_infcall_mmap (struct gdbarch *gdbarch, gdbarch_infcall_mmap_ftype *infcall_mmap);
+
+/* Return string (caller has to use xfree for it) with options for GCC
+ to produce code for this target, typically "-m64", "-m32" or "-m31".
+ These options are put before CU's DW_AT_producer compilation options so that
+ they can override it. Method may also return NULL. */
+
+typedef char * (gdbarch_gcc_target_options_ftype) (struct gdbarch *gdbarch);
+extern char * gdbarch_gcc_target_options (struct gdbarch *gdbarch);
+extern void set_gdbarch_gcc_target_options (struct gdbarch *gdbarch, gdbarch_gcc_target_options_ftype *gcc_target_options);
+
/* Definition for an unknown syscall, used basically in error-cases. */
#define UNKNOWN_SYSCALL (-1)
diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
index 9f357b6..6b2bc12 100755
--- a/gdb/gdbarch.sh
+++ b/gdb/gdbarch.sh
@@ -1029,6 +1029,18 @@ m:int:insn_is_jump:CORE_ADDR addr:addr::default_insn_is_jump::0
# Return -1 if there is insufficient buffer for a whole entry.
# Return 1 if an entry was read into *TYPEP and *VALP.
M:int:auxv_parse:gdb_byte **readptr, gdb_byte *endptr, CORE_ADDR *typep, CORE_ADDR *valp:readptr, endptr, typep, valp
+
+# Allocate SIZE bytes of PROT protected page aligned memory in inferior.
+# PROT has rwx bitmask format - bit 2 (value 4) is for readable memory, bit 1
+# (value 2) is for writable memory and bit 0 (value 1) is for executable memory.
+# Throw an error if it is not possible. Returned address is always valid.
+f:CORE_ADDR:infcall_mmap:CORE_ADDR size, unsigned prot:size, prot::default_infcall_mmap::0
+
+# Return string (caller has to use xfree for it) with options for GCC
+# to produce code for this target, typically "-m64", "-m32" or "-m31".
+# These options are put before CU's DW_AT_producer compilation options so that
+# they can override it. Method may also return NULL.
+m:char *:gcc_target_options:void:::default_gcc_target_options::0
EOF
}
--
1.9.0
next prev parent reply other threads:[~2014-05-16 15:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 15:26 [PATCH 00/14] let gdb reuse gcc's C compiler Tom Tromey
2014-05-16 15:26 ` [PATCH 02/14] add gcc/gdb interface files Tom Tromey
2014-05-19 8:06 ` Yao Qi
2014-05-19 13:53 ` Tom Tromey
2014-05-16 15:26 ` [PATCH 08/14] introduce call_function_by_hand_dummy Tom Tromey
2014-05-16 15:26 ` [PATCH 01/14] introduce ui_file_write_for_put Tom Tromey
2014-05-16 15:26 ` Tom Tromey [this message]
2014-05-19 6:13 ` [PATCH 07/14] add infcall_mmap and gcc_target_options gdbarch methods Yao Qi
2014-05-19 6:41 ` Jan Kratochvil
2014-05-19 6:47 ` Jan Kratochvil
2014-05-19 7:42 ` Yao Qi
2014-05-19 8:26 ` Agovic, Sanimir
2014-05-19 11:15 ` Jan Kratochvil
2014-05-16 15:26 ` [PATCH 10/14] make dwarf_expr_frame_base_1 public Tom Tromey
2014-05-16 15:26 ` [PATCH 03/14] add some missing ops to DWARF assembler Tom Tromey
2014-05-16 15:27 ` [PATCH 14/14] the "compile" command Tom Tromey
2014-06-16 9:55 ` (Doc ping [for news and manual]) -- " Phil Muldoon
2014-06-16 15:25 ` Eli Zaretskii
2014-06-20 9:17 ` Phil Muldoon
2014-06-20 9:42 ` Eli Zaretskii
2014-06-20 10:01 ` Phil Muldoon
2014-06-20 12:37 ` Eli Zaretskii
2014-06-20 14:42 ` Tom Tromey
2014-06-20 19:00 ` Eli Zaretskii
2014-06-21 7:32 ` Eli Zaretskii
2014-05-16 15:41 ` [PATCH 05/14] change how the CLI handles comments Tom Tromey
2014-05-18 23:26 ` Doug Evans
2014-05-19 14:07 ` Phil Muldoon
2014-06-03 7:04 ` Doug Evans
2014-05-16 15:43 ` [PATCH 09/14] split dwarf2_fetch_cfa_info from dwarf2_compile_expr_to_ax Tom Tromey
2014-05-16 15:43 ` [PATCH 13/14] add s390_gcc_target_options Tom Tromey
2014-05-16 15:43 ` [PATCH 12/14] add linux_infcall_mmap Tom Tromey
2014-05-16 15:56 ` [PATCH 04/14] add make_unqualified_type Tom Tromey
2014-05-16 16:18 ` [PATCH 06/14] add dummy frame destructor Tom Tromey
2014-05-16 16:18 ` [PATCH 11/14] export dwarf2_reg_to_regnum_or_error Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400253995-12333-8-git-send-email-tromey@redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).