public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [PATCH v2 03/14] add some missing ops to DWARF assembler
Date: Fri, 20 Jun 2014 15:58:00 -0000	[thread overview]
Message-ID: <1403279874-23781-4-git-send-email-tromey@redhat.com> (raw)
In-Reply-To: <1403279874-23781-1-git-send-email-tromey@redhat.com>

This changes the DWARF assembler to allow comments in a location
expression, and also adds support for a few new opcodes I needed.

2014-06-20  Tom Tromey  <tromey@redhat.com>

	* lib/dwarf.exp (_location): Ignore blank lines.  Allow comments.
	Handle DW_OP_pick, DW_OP_skip, DW_OP_bra.
---
 gdb/testsuite/ChangeLog     | 5 +++++
 gdb/testsuite/lib/dwarf.exp | 9 ++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp
index 1483271..eac2c80 100644
--- a/gdb/testsuite/lib/dwarf.exp
+++ b/gdb/testsuite/lib/dwarf.exp
@@ -678,7 +678,8 @@ namespace eval Dwarf {
 	variable _cu_offset_size
 
 	foreach line [split $body \n] {
-	    if {[lindex $line 0] == ""} {
+	    # Ignore blank lines, and allow embedded comments.
+	    if {[lindex $line 0] == "" || [regexp -- {^[ \t]*#} $line]} {
 		continue
 	    }
 	    set opcode [_map_name [lindex $line 0] _OP]
@@ -689,6 +690,7 @@ namespace eval Dwarf {
 		    _op .${_cu_addr_size}byte [lindex $line 1]
 		}
 
+		DW_OP_pick -
 		DW_OP_const1u -
 		DW_OP_const1s {
 		    _op .byte [lindex $line 1]
@@ -729,6 +731,11 @@ namespace eval Dwarf {
 		    _op .uleb128 [lindex $line 2]
 		}
 
+		DW_OP_skip -
+		DW_OP_bra {
+		    _op .2byte [lindex $line 1]
+		}
+
 		DW_OP_GNU_implicit_pointer {
 		    if {[llength $line] != 3} {
 			error "usage: DW_OP_GNU_implicit_pointer LABEL OFFSET"
-- 
1.9.3

  parent reply	other threads:[~2014-06-20 15:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 15:58 [PATCH v2 00/15] let gdb reuse gcc's C compiler Tom Tromey
2014-06-20 15:58 ` [PATCH v2 02/14] add gcc/gdb interface files Tom Tromey
2014-06-20 15:58 ` [PATCH v2 01/14] introduce ui_file_write_for_put Tom Tromey
2014-06-20 15:58 ` Tom Tromey [this message]
2014-06-20 15:58 ` [PATCH v2 14/14] the "compile" command Tom Tromey
2014-06-20 19:17   ` Eli Zaretskii
2014-10-08 17:45     ` Jan Kratochvil
2014-10-08 18:42       ` Eli Zaretskii
2014-10-08 19:42         ` Jan Kratochvil
2014-06-20 15:58 ` [PATCH v2 09/14] split dwarf2_fetch_cfa_info from dwarf2_compile_expr_to_ax Tom Tromey
2014-06-20 15:58 ` [PATCH v2 04/14] add make_unqualified_type Tom Tromey
2014-06-20 15:58 ` [PATCH v2 11/14] export dwarf2_reg_to_regnum_or_error Tom Tromey
2014-06-20 16:26 ` [PATCH v2 13/14] add s390_gcc_target_options Tom Tromey
2014-06-20 16:32 ` [PATCH v2 07/14] add gnu_triplet_regexp gdbarch method Tom Tromey
2014-06-20 16:32 ` [PATCH v2 12/14] add linux_infcall_mmap Tom Tromey
2014-06-20 16:32 ` [PATCH v2 05/14] add dummy frame destructor Tom Tromey
2014-06-20 16:33 ` [PATCH v2 10/14] make dwarf_expr_frame_base_1 public Tom Tromey
2014-06-20 20:05   ` Doug Evans
2014-06-23  8:18     ` Gary Benson
2014-06-23 14:57       ` Eli Zaretskii
2014-06-24 10:18         ` Gary Benson
2014-06-24 13:04           ` Pedro Alves
2014-10-08 16:57             ` Jan Kratochvil
2014-06-20 16:39 ` [PATCH v2 08/14] introduce call_function_by_hand_dummy Tom Tromey
2014-06-20 16:51 ` [PATCH v2 06/14] add infcall_mmap and gcc_target_options gdbarch methods Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403279874-23781-4-git-send-email-tromey@redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).