From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6845 invoked by alias); 2 Jul 2014 19:14:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6720 invoked by uid 89); 2 Jul 2014 19:13:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 02 Jul 2014 19:13:56 +0000 Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id F2.EE.25146.E9504B35; Wed, 2 Jul 2014 15:14:07 +0200 (CEST) Received: from elx67nvvz1-ei.localdomain (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.96) with Microsoft SMTP Server (TLS) id 14.3.174.1; Wed, 2 Jul 2014 15:13:53 -0400 From: Marc Khouzam To: CC: Marc Khouzam Subject: [PATCH] Assign 'targerr' instead of 'targ' to gdb_stdtargerr. Date: Wed, 02 Jul 2014 19:14:00 -0000 Message-ID: <1404328417-28116-1-git-send-email-marc.khouzam@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00037.txt.bz2 Hi, I noticed this what-seems-to-be-typo when browsing the code. I'm not sure if the target can have two distinct streams or not but the code seems to think so. I figure might as well fix it. The original suspicious code was introduced at the same time as when saved_output.targerr was added, so it really does look like a typo. It was in commit 8d4d924b. Is this ok? Thanks 2014-07-02 Marc Khouzam * cli/cli-logging.c (pop_output_files): Assign targerr to gdb_stdtargerr. diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c index ca2d76e..aae0039 100644 --- a/gdb/cli/cli-logging.c +++ b/gdb/cli/cli-logging.c @@ -171,7 +171,7 @@ pop_output_files (void) gdb_stderr = saved_output.err; gdb_stdlog = saved_output.log; gdb_stdtarg = saved_output.targ; - gdb_stdtargerr = saved_output.targ; + gdb_stdtargerr = saved_output.targerr; } saved_output.out = NULL; -- 1.7.9.5