From: Gary Benson <gbenson@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>, Doug Evans <dje@google.com>
Subject: [PATCH 03/15 v2] Make gdbserver CORE_ADDR unsigned
Date: Wed, 16 Jul 2014 16:48:00 -0000 [thread overview]
Message-ID: <1405520243-17282-4-git-send-email-gbenson@redhat.com> (raw)
In-Reply-To: <1405520243-17282-1-git-send-email-gbenson@redhat.com>
gdbserver defines CORE_ADDR to be signed. This seems erroneous to
me; and furthermore likely to cause problems in common/, as it is
different from gdb's definition.
gdb/gdbserver/
2014-07-16 Tom Tromey <tromey@redhat.com>
Gary Benson <gbenson@redhat.com>
* server.h (CORE_ADDR): Now unsigned.
---
gdb/gdbserver/ChangeLog | 5 +++++
gdb/gdbserver/server.h | 2 +-
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/gdb/gdbserver/server.h b/gdb/gdbserver/server.h
index 6eb1a16..2d55513 100644
--- a/gdb/gdbserver/server.h
+++ b/gdb/gdbserver/server.h
@@ -87,7 +87,7 @@ typedef unsigned char gdb_byte;
/* FIXME: This should probably be autoconf'd for. It's an integer type at
least the size of a (void *). */
-typedef long long CORE_ADDR;
+typedef unsigned long long CORE_ADDR;
typedef long long LONGEST;
typedef unsigned long long ULONGEST;
--
1.7.1
next prev parent reply other threads:[~2014-07-16 16:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 16:19 [PATCH 00/15 v2] Common code cleanups Gary Benson
2014-07-16 16:19 ` [PATCH 15/15 v2] Finally remove GDBSERVER (mostly) from linux-btrace.c Gary Benson
2014-07-16 16:19 ` [PATCH 04/15 v2] Introduce common-types.h Gary Benson
2014-07-17 11:21 ` Doug Evans
2014-07-16 16:32 ` [PATCH 09/15 v2] Mostly remove GDBSERVER from linux-waitpid.c Gary Benson
2014-07-16 16:33 ` [PATCH 14/15 v2] Introduce get_thread_regcache_for_ptid Gary Benson
2014-07-16 16:45 ` [PATCH 05/15 v2] Introduce and use debug_printf and debug_vprintf Gary Benson
2014-07-16 16:45 ` [PATCH 02/15 v2] Remove some GDBSERVER checks from linux-ptrace Gary Benson
2014-07-17 8:37 ` Doug Evans
2014-07-17 16:40 ` Pedro Alves
2014-07-16 16:45 ` [PATCH 01/15 v2] Introduce common/errors.h Gary Benson
2014-07-16 18:36 ` Doug Evans
2014-07-17 13:41 ` [PATCH] " Gary Benson
2014-07-17 13:47 ` Gary Benson
2014-07-17 14:05 ` [PATCH 01/15 v3] " Gary Benson
2014-07-17 15:40 ` Pedro Alves
2014-07-17 16:03 ` Gary Benson
2014-07-17 16:19 ` Pedro Alves
2014-07-18 9:20 ` Gary Benson
2014-07-18 10:42 ` Doug Evans
2014-07-18 11:23 ` Gary Benson
2014-07-18 12:31 ` Doug Evans
2014-07-18 10:44 ` Pedro Alves
2014-07-16 16:48 ` [PATCH 06/15 v2] Remove simple GDBSERVER uses from common, nat and target Gary Benson
2014-07-16 16:48 ` Gary Benson [this message]
2014-07-17 9:02 ` [PATCH 03/15 v2] Make gdbserver CORE_ADDR unsigned Doug Evans
2014-07-17 16:42 ` Pedro Alves
2014-07-18 8:07 ` Maciej W. Rozycki
2014-07-16 17:03 ` [PATCH 11/15 v2] More target unification Gary Benson
2014-07-16 17:03 ` [PATCH 08/15 v2] Make btrace-common.h not use GDBSERVER Gary Benson
2014-07-16 17:03 ` [PATCH 13/15 v2] Finally remove GDBSERVER (mostly) from agent.c Gary Benson
2014-07-16 17:04 ` [PATCH 10/15 v2] Add target/target.h Gary Benson
2014-07-16 17:20 ` [PATCH 12/15 v2] Add target/symbol.h, update users Gary Benson
2014-07-16 17:24 ` [PATCH 07/15 v2] Remove GDBSERVER use from nat/i386-dregs.c Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405520243-17282-4-git-send-email-gbenson@redhat.com \
--to=gbenson@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).