* [PATCH] Introduce remote_target_is_gdbserver
@ 2014-09-05 20:18 Simon Marchi
0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2014-09-05 20:18 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
This patch introduces a function in gdbserver-support.exp to find out
whether the current target is GDBserver.
The code was inspired from gdb.trace/qtor.exp, so it replaces the code
there by a call to the new function.
gdb/testsuite/ChangeLog:
* lib/gdbserver-support.exp (remote_target_is_gdbserver): New
fonction.
---
gdb/testsuite/gdb.trace/qtro.exp | 14 +-------------
gdb/testsuite/lib/gdbserver-support.exp | 23 +++++++++++++++++++++++
2 files changed, 24 insertions(+), 13 deletions(-)
diff --git a/gdb/testsuite/gdb.trace/qtro.exp b/gdb/testsuite/gdb.trace/qtro.exp
index 22b5051..61be360 100644
--- a/gdb/testsuite/gdb.trace/qtro.exp
+++ b/gdb/testsuite/gdb.trace/qtro.exp
@@ -98,19 +98,7 @@ if { $traceframe_info_supported == -1 } {
}
# Check whether we're testing with our own GDBserver.
-set is_gdbserver -1
-set test "probe for GDBserver"
-gdb_test_multiple "monitor help" $test {
- -re "The following monitor commands are supported.*debug-hw-points.*remote-debug.*GDBserver.*$gdb_prompt $" {
- set is_gdbserver 1
- pass $test
- }
- -re "$gdb_prompt $" {
- set is_gdbserver 0
- pass $test
- }
-}
-if { $is_gdbserver == -1 } {
+if {[is_remote target] && ![target_is_gdbserver]} {
return -1
}
diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gdbserver-support.exp
index 8c91e28..9aad90b 100644
--- a/gdb/testsuite/lib/gdbserver-support.exp
+++ b/gdb/testsuite/lib/gdbserver-support.exp
@@ -419,3 +419,26 @@ proc mi_gdbserver_start_multi { } {
return [mi_gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport]
}
+
+# Return true if the current remote target is an instance of gdbserver.
+
+proc target_is_gdbserver { } {
+ global gdb_prompt
+
+ set is_gdbserver 0
+ set test "Probing for GDBserver"
+
+ gdb_test_multiple "monitor help" $test {
+ -re "The following monitor commands are supported.*Quit GDBserver.*$gdb_prompt $" {
+ pass $test
+ set is_gdbserver 1
+ }
+ -re "$gdb_prompt $" {
+ pass $test
+ }
+ default {
+ pass $test
+ }
+ }
+ return $is_gdbserver
+}
--
2.1.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-09-05 20:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-05 20:18 [PATCH] Introduce remote_target_is_gdbserver Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).