From: Keven Boell <keven.boell@intel.com>
To: gdb-patches@sourceware.org
Cc: sanimir.agovic@intel.com, Keven Boell <keven.boell@intel.com>
Subject: [V3 04/21] vla: reconstruct value to compute bounds of target type
Date: Wed, 10 Sep 2014 09:22:00 -0000 [thread overview]
Message-ID: <1410340929-20653-5-git-send-email-keven.boell@intel.com> (raw)
In-Reply-To: <1410340929-20653-1-git-send-email-keven.boell@intel.com>
Printing a pointer to an array, gdb tries to print the
target type including its bounds. To follow this
semantic with vla, this patch re-constructs the value to
resolve the bounds of the target type.
2014-05-28 Sanimir Agovic <sanimir.agovic@intel.com>
Keven Boell <keven.boell@intel.com>
* typeprint.c (whatis_exp): Re-construct value to
compute bounds of target type.
* c-valprint.c (c_value_print): Re-construct value
to compute bounds of target type.
---
gdb/c-valprint.c | 11 ++++++++++-
gdb/f-typeprint.c | 6 +++++-
gdb/typeprint.c | 7 +++++++
3 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/gdb/c-valprint.c b/gdb/c-valprint.c
index 17963f0..955cca5 100644
--- a/gdb/c-valprint.c
+++ b/gdb/c-valprint.c
@@ -537,7 +537,16 @@ c_value_print (struct value *val, struct ui_file *stream,
{
/* normal case */
fprintf_filtered (stream, "(");
- type_print (value_type (val), "", stream, -1);
+ if (is_dynamic_type (TYPE_TARGET_TYPE (type)))
+ {
+ struct value *v;
+
+ v = value_ind (val);
+ v = value_addr (v);
+ type_print (value_type (v), "", stream, -1);
+ }
+ else
+ type_print (value_type (val), "", stream, -1);
fprintf_filtered (stream, ") ");
}
}
diff --git a/gdb/f-typeprint.c b/gdb/f-typeprint.c
index be719c6..b97e736 100644
--- a/gdb/f-typeprint.c
+++ b/gdb/f-typeprint.c
@@ -85,7 +85,11 @@ f_print_type (struct type *type, const char *varstring, struct ui_file *stream,
/* For demangled function names, we have the arglist as part of the name,
so don't print an additional pair of ()'s. */
- demangled_args = varstring[strlen (varstring) - 1] == ')';
+ if (strlen (varstring) > 0)
+ demangled_args = varstring[strlen (varstring) - 1] == ')';
+ else
+ demangled_args = 0;
+
f_type_print_varspec_suffix (type, stream, show, 0, demangled_args, 0);
}
}
diff --git a/gdb/typeprint.c b/gdb/typeprint.c
index 4d3358f..2f60ff5 100644
--- a/gdb/typeprint.c
+++ b/gdb/typeprint.c
@@ -457,6 +457,13 @@ whatis_exp (char *exp, int show)
type = value_type (val);
+ if (TYPE_CODE (type) == TYPE_CODE_PTR)
+ if (is_dynamic_type (TYPE_TARGET_TYPE (type)))
+ {
+ val = value_addr (value_ind (val));
+ type = value_type (val);
+ }
+
get_user_print_options (&opts);
if (opts.objectprint)
{
--
1.7.9.5
next prev parent reply other threads:[~2014-09-10 9:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 9:22 [V3 00/21] Fortran dynamic array support Keven Boell
2014-09-10 9:22 ` [V3 06/21] vla: get dynamic array corner cases to work Keven Boell
2014-09-10 9:22 ` [V3 17/21] test: accessing dynamic array history values Keven Boell
2014-09-10 9:22 ` [V3 20/21] test: test sizeof for dynamic fortran arrays Keven Boell
2014-09-10 9:22 ` [V3 10/21] vla: add NEWS entry for dynamic array support Keven Boell
2014-09-10 17:03 ` Eli Zaretskii
2014-09-10 9:22 ` [V3 12/21] test: evaluate dynamic arrays using Fortran primitives Keven Boell
2014-09-10 9:22 ` Keven Boell [this message]
2014-09-10 9:22 ` [V3 11/21] test: basic tests for dynamic array evaluations in Fortran Keven Boell
2014-09-10 9:22 ` [V3 19/21] test: basic MI test for the dynamic array support Keven Boell
2014-09-10 9:22 ` [V3 08/21] vla: get Fortran dynamic strings working Keven Boell
2014-09-10 9:22 ` [V3 07/21] vla: changed string length semantic Keven Boell
2014-09-10 9:22 ` [V3 16/21] test: dynamic arrays passed to functions Keven Boell
2014-09-10 9:22 ` [V3 14/21] test: correct ptype of dynamic arrays in Fortran Keven Boell
2014-09-10 9:22 ` [V3 09/21] vla: add stride support to fortran arrays Keven Boell
2014-09-10 9:22 ` [V3 18/21] test: dynamic string evaluations Keven Boell
2014-09-10 9:22 ` [V3 02/21] vla: make dynamic fortran arrays functional Keven Boell
2014-09-10 9:22 ` [V3 05/21] vla: use value constructor instead of raw-buffer manipulation Keven Boell
2014-09-10 9:22 ` [V3 21/21] test: stride support for dynamic arrays Keven Boell
2014-09-10 9:22 ` [V3 15/21] test: evaluating allocation/association status Keven Boell
2014-09-10 9:22 ` [V3 01/21] vla: introduce allocated/associated flags Keven Boell
2014-09-10 9:22 ` [V3 03/21] vla: make field selection work with vla Keven Boell
2014-09-10 9:22 ` [V3 13/21] test: dynamic arrays passed to subroutines Keven Boell
2014-10-02 8:35 ` PING: [V3 00/21] Fortran dynamic array support Tobias Burnus
2014-10-02 15:00 ` Joel Brobecker
2014-11-17 8:59 ` Tobias Burnus
2014-11-17 10:05 ` Joel Brobecker
2014-12-09 8:00 ` Tobias Burnus
2014-12-09 9:18 ` Joel Brobecker
2014-12-09 10:03 ` Keven Boell
2015-02-04 13:22 ` Tobias Burnus
2015-02-04 14:18 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410340929-20653-5-git-send-email-keven.boell@intel.com \
--to=keven.boell@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=sanimir.agovic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).