From: Keven Boell <keven.boell@intel.com>
To: gdb-patches@sourceware.org
Cc: sanimir.agovic@intel.com, Keven Boell <keven.boell@intel.com>
Subject: [V3 08/21] vla: get Fortran dynamic strings working.
Date: Wed, 10 Sep 2014 09:22:00 -0000 [thread overview]
Message-ID: <1410340929-20653-9-git-send-email-keven.boell@intel.com> (raw)
In-Reply-To: <1410340929-20653-1-git-send-email-keven.boell@intel.com>
This patch enables the correct calculation of dynamic
string length.
Old:
(gdb) p my_dyn_string
$1 = (PTR TO -> ( character*23959136 )) 0x605fc0
(gdb) p *my_dyn_string
Cannot access memory at address 0x605fc0
New:
(gdb) p my_dyn_string
$1 = (PTR TO -> ( character*10 )) 0x605fc0
(gdb) p *my_dyn_string
$2 = 'foo'
2014-05-28 Keven Boell <keven.boell@intel.com>
Sanimir Agovic <sanimir.agovic@intel.com>
* gdbtypes.c (resolve_dynamic_type): Add
conditions to support string types.
(resolve_dynamic_array): Add conditions for dynamic
strings and create a new string type.
(is_dynamic_type): Follow pointer if a string type
was detected, as Fortran strings are represented
as pointers to strings internally.
---
gdb/gdbtypes.c | 29 ++++++++++++++++++++++++-----
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 9653c6f..29c1dbd 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -1677,6 +1677,17 @@ is_dynamic_type_internal (struct type *type, int top_level)
&& is_dynamic_type_internal (TYPE_FIELD_TYPE (type, i), 0))
return 1;
}
+ case TYPE_CODE_PTR:
+ {
+ if (TYPE_TARGET_TYPE (type)
+ && TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_STRING)
+ return is_dynamic_type (check_typedef (TYPE_TARGET_TYPE (type)));
+
+ return 0;
+ break;
+ }
+ default:
+ return 0;
break;
}
@@ -1759,7 +1770,8 @@ resolve_dynamic_array (struct type *type, CORE_ADDR addr)
struct dynamic_prop *prop;
struct type *copy = copy_type (type);
- gdb_assert (TYPE_CODE (type) == TYPE_CODE_ARRAY);
+ gdb_assert (TYPE_CODE (type) == TYPE_CODE_ARRAY
+ || TYPE_CODE (type) == TYPE_CODE_STRING);
elt_type = type;
range_type = check_typedef (TYPE_INDEX_TYPE (elt_type));
@@ -1781,14 +1793,20 @@ resolve_dynamic_array (struct type *type, CORE_ADDR addr)
ary_dim = check_typedef (TYPE_TARGET_TYPE (elt_type));
- if (ary_dim != NULL && TYPE_CODE (ary_dim) == TYPE_CODE_ARRAY)
+ if (ary_dim != NULL && (TYPE_CODE (ary_dim) == TYPE_CODE_ARRAY
+ || TYPE_CODE (ary_dim) == TYPE_CODE_STRING))
elt_type = resolve_dynamic_array (TYPE_TARGET_TYPE (copy), addr);
else
elt_type = TYPE_TARGET_TYPE (type);
- return create_array_type (copy,
- elt_type,
- range_type);
+ if (TYPE_CODE (type) == TYPE_CODE_STRING)
+ return create_string_type (copy,
+ elt_type,
+ range_type);
+ else
+ return create_array_type (copy,
+ elt_type,
+ range_type);
}
/* Resolve dynamic bounds of members of the union TYPE to static
@@ -1927,6 +1945,7 @@ resolve_dynamic_type_internal (struct type *type, CORE_ADDR addr,
}
case TYPE_CODE_ARRAY:
+ case TYPE_CODE_STRING:
resolved_type = resolve_dynamic_array (type, addr);
break;
--
1.7.9.5
next prev parent reply other threads:[~2014-09-10 9:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 9:22 [V3 00/21] Fortran dynamic array support Keven Boell
2014-09-10 9:22 ` [V3 13/21] test: dynamic arrays passed to subroutines Keven Boell
2014-09-10 9:22 ` [V3 03/21] vla: make field selection work with vla Keven Boell
2014-09-10 9:22 ` [V3 01/21] vla: introduce allocated/associated flags Keven Boell
2014-09-10 9:22 ` [V3 15/21] test: evaluating allocation/association status Keven Boell
2014-09-10 9:22 ` [V3 21/21] test: stride support for dynamic arrays Keven Boell
2014-09-10 9:22 ` [V3 02/21] vla: make dynamic fortran arrays functional Keven Boell
2014-09-10 9:22 ` [V3 18/21] test: dynamic string evaluations Keven Boell
2014-09-10 9:22 ` [V3 05/21] vla: use value constructor instead of raw-buffer manipulation Keven Boell
2014-09-10 9:22 ` [V3 09/21] vla: add stride support to fortran arrays Keven Boell
2014-09-10 9:22 ` [V3 14/21] test: correct ptype of dynamic arrays in Fortran Keven Boell
2014-09-10 9:22 ` [V3 16/21] test: dynamic arrays passed to functions Keven Boell
2014-09-10 9:22 ` [V3 19/21] test: basic MI test for the dynamic array support Keven Boell
2014-09-10 9:22 ` Keven Boell [this message]
2014-09-10 9:22 ` [V3 07/21] vla: changed string length semantic Keven Boell
2014-09-10 9:22 ` [V3 11/21] test: basic tests for dynamic array evaluations in Fortran Keven Boell
2014-09-10 9:22 ` [V3 04/21] vla: reconstruct value to compute bounds of target type Keven Boell
2014-09-10 9:22 ` [V3 12/21] test: evaluate dynamic arrays using Fortran primitives Keven Boell
2014-09-10 9:22 ` [V3 10/21] vla: add NEWS entry for dynamic array support Keven Boell
2014-09-10 17:03 ` Eli Zaretskii
2014-09-10 9:22 ` [V3 20/21] test: test sizeof for dynamic fortran arrays Keven Boell
2014-09-10 9:22 ` [V3 06/21] vla: get dynamic array corner cases to work Keven Boell
2014-09-10 9:22 ` [V3 17/21] test: accessing dynamic array history values Keven Boell
2014-10-02 8:35 ` PING: [V3 00/21] Fortran dynamic array support Tobias Burnus
2014-10-02 15:00 ` Joel Brobecker
2014-11-17 8:59 ` Tobias Burnus
2014-11-17 10:05 ` Joel Brobecker
2014-12-09 8:00 ` Tobias Burnus
2014-12-09 9:18 ` Joel Brobecker
2014-12-09 10:03 ` Keven Boell
2015-02-04 13:22 ` Tobias Burnus
2015-02-04 14:18 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410340929-20653-9-git-send-email-keven.boell@intel.com \
--to=keven.boell@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=sanimir.agovic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).