From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [pushed] Fix features/i386/64bit-avx512.xml
Date: Wed, 01 Oct 2014 10:07:00 -0000 [thread overview]
Message-ID: <1412158019-2094-1-git-send-email-palves@redhat.com> (raw)
This file's format is invalid, as it's missing some end quotes.
I noticed this because I tried to regenerate all the .dat files in
gdb/regformats/. I got:
sh ../../move-if-change ../regformats/i386/x32-avx.tmp ../regformats/i386/x32-avx.dat
echo "# DO NOT EDIT: generated from i386/x32-avx512.xml" > ../regformats/i386/x32-avx512.tmp
echo "name:`echo x32-avx512 | sed 's/-/_/g'`" >> ../regformats/i386/x32-avx512.tmp
echo "xmltarget:x32-avx512.xml" >> ../regformats/i386/x32-avx512.tmp
echo "expedite:rbp,rsp,rip" \
>> ../regformats/i386/x32-avx512.tmp
xsltproc --path "/home/pedro/gdb/mygit/src/gdb/features" --xinclude number-regs.xsl i386/x32-avx512.xml | \
xsltproc sort-regs.xsl - | \
xsltproc gdbserver-regs.xsl - >> ../regformats/i386/x32-avx512.tmp
i386/64bit-avx512.xml:81: parser error : Unescaped '<' not allowed in attributes values
<reg name="zmm11h" bitsize="256" type="v2ui128/>
^
i386/64bit-avx512.xml:81: parser error : attributes construct error
<reg name="zmm11h" bitsize="256" type="v2ui128/>
^
i386/64bit-avx512.xml:81: parser error : Couldn't find end of Start Tag reg line 80
<reg name="zmm11h" bitsize="256" type="v2ui128/>
^
i386/64bit-avx512.xml:82: parser error : Unescaped '<' not allowed in attributes values
<reg name="zmm12h" bitsize="256" type="v2ui128/>
^
i386/64bit-avx512.xml:82: parser error : attributes construct error
<reg name="zmm12h" bitsize="256" type="v2ui128/>
^
...
i386/x32-avx512.xml:17: element include: XInclude error : could not load i386/64bit-avx512.xml, and no fallback was found
-:1: parser error : Document is empty
^
-:1: parser error : Start tag expected, '<' not found
^
unable to parse -
-:1: parser error : Document is empty
^
-:1: parser error : Start tag expected, '<' not found
^
unable to parse -
make: *** [../regformats/i386/x32-avx512.dat] Error 6
Interestingly, gdb/expat manages to grok the broken file.
gdb/
2014-10-01 Pedro Alves <palves@redhat.com>
* features/i386/64bit-avx512.xml (zmm10h, zmm11h, zmm12h, zmm13h)
(zmm14h): Add missing end quotes.
---
gdb/ChangeLog | 5 +++++
gdb/features/i386/64bit-avx512.xml | 10 +++++-----
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 46bc965..0ba9f44 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2014-10-01 Pedro Alves <palves@redhat.com>
+ * features/i386/64bit-avx512.xml (zmm10h, zmm11h, zmm12h, zmm13h)
+ (zmm14h): Add missing end quotes.
+
+2014-10-01 Pedro Alves <palves@redhat.com>
+
* features/aarch64-core.xml (cpsr): Change back to 32-bit.
* features/aarch64.c: Regenerate.
diff --git a/gdb/features/i386/64bit-avx512.xml b/gdb/features/i386/64bit-avx512.xml
index 5e2bf9f..c6c158a 100644
--- a/gdb/features/i386/64bit-avx512.xml
+++ b/gdb/features/i386/64bit-avx512.xml
@@ -77,11 +77,11 @@
<reg name="zmm7h" bitsize="256" type="v2ui128"/>
<reg name="zmm8h" bitsize="256" type="v2ui128"/>
<reg name="zmm9h" bitsize="256" type="v2ui128"/>
- <reg name="zmm10h" bitsize="256" type="v2ui128/>
- <reg name="zmm11h" bitsize="256" type="v2ui128/>
- <reg name="zmm12h" bitsize="256" type="v2ui128/>
- <reg name="zmm13h" bitsize="256" type="v2ui128/>
- <reg name="zmm14h" bitsize="256" type="v2ui128/>
+ <reg name="zmm10h" bitsize="256" type="v2ui128"/>
+ <reg name="zmm11h" bitsize="256" type="v2ui128"/>
+ <reg name="zmm12h" bitsize="256" type="v2ui128"/>
+ <reg name="zmm13h" bitsize="256" type="v2ui128"/>
+ <reg name="zmm14h" bitsize="256" type="v2ui128"/>
<reg name="zmm15h" bitsize="256" type="v2ui128"/>
<reg name="zmm16h" bitsize="256" type="v2ui128"/>
<reg name="zmm17h" bitsize="256" type="v2ui128"/>
--
1.9.3
reply other threads:[~2014-10-01 10:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412158019-2094-1-git-send-email-palves@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).