From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] Fix a set of terminal/readline handling bugs/crashes
Date: Thu, 09 Oct 2014 18:00:00 -0000 [thread overview]
Message-ID: <1412877629-12052-1-git-send-email-palves@redhat.com> (raw)
This series fixes a couple terminal/readline handling bugs that result
in GDB crashing with:
readline: readline_callback_read_char() called with no handler!
Aborted (core dumped)
$
... and also a bug where we lose the "&" when repeating background
commands.
Because the these won't trigger without target-async, the first two
are user-visible regressions in 7.8, which has async by default (7.7
didn't). As such, I'd like to include these in 7.8.1.
For last one (gdb/17471), I'm a bit borderline (re. 7.8.1).
Technically, it isn't really a regression, but still annoying (see
gdb/17300). If you'd prefer not having that in 7.8.1, please do speak
up.
Tested on x86_64 Fedora 20, native and gdbserver.
Pedro Alves (4):
Make common code handle target_terminal_* idempotency
PR gdb/17472: With annotations, input while executing in the
foreground crashes readline/GDB
PR gdb/17300: Input after "c -a" crashes readline/GDB
PR gdb/17471: Repeating a background command makes it foreground
gdb/annotate.c | 22 ++-
gdb/infcmd.c | 160 ++++++++++++++-------
gdb/target.c | 64 +++++++++
gdb/target.h | 25 ++--
.../gdb.base/annota-input-while-running.c | 25 ++++
.../gdb.base/annota-input-while-running.exp | 130 +++++++++++++++++
gdb/testsuite/gdb.base/bg-execution-repeat.c | 33 +++++
gdb/testsuite/gdb.base/bg-execution-repeat.exp | 86 +++++++++++
.../gdb.base/continue-all-already-running.c | 25 ++++
.../gdb.base/continue-all-already-running.exp | 79 ++++++++++
gdb/windows-nat.c | 2 +-
11 files changed, 582 insertions(+), 69 deletions(-)
create mode 100644 gdb/testsuite/gdb.base/annota-input-while-running.c
create mode 100644 gdb/testsuite/gdb.base/annota-input-while-running.exp
create mode 100644 gdb/testsuite/gdb.base/bg-execution-repeat.c
create mode 100644 gdb/testsuite/gdb.base/bg-execution-repeat.exp
create mode 100644 gdb/testsuite/gdb.base/continue-all-already-running.c
create mode 100644 gdb/testsuite/gdb.base/continue-all-already-running.exp
--
1.9.3
next reply other threads:[~2014-10-09 18:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 18:00 Pedro Alves [this message]
2014-10-09 18:00 ` [PATCH 2/4] PR gdb/17472: With annotations, input while executing in the foreground crashes readline/GDB Pedro Alves
2014-10-09 18:00 ` [PATCH 4/4] PR gdb/17471: Repeating a background command makes it foreground Pedro Alves
2015-08-03 21:02 ` [patch] ASAN attach crash - 7.9 regression [Re: [PATCH 4/4] PR gdb/17471: Repeating a background command makes it foreground] Jan Kratochvil
2015-08-04 8:35 ` Pedro Alves
2015-08-04 11:48 ` [commit+7.10] " Jan Kratochvil
2015-08-25 15:47 ` Jan Kratochvil
2015-08-04 8:28 ` [patch] signal_command: Leftover cleanup chain " Jan Kratochvil
2015-08-04 8:37 ` Pedro Alves
2015-08-04 11:49 ` [commit+7.10] " Jan Kratochvil
2015-08-25 15:48 ` Jan Kratochvil
2014-10-09 18:00 ` [PATCH 1/4] Make common code handle target_terminal_* idempotency Pedro Alves
2014-10-09 18:00 ` [PATCH 3/4] PR gdb/17300: Input after "c -a" crashes readline/GDB Pedro Alves
2014-10-17 13:39 ` [pushed] Re: [PATCH 0/4] Fix a set of terminal/readline handling bugs/crashes Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412877629-12052-1-git-send-email-palves@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).