[PATCH] checkpoint: print index of new checkpoint in response message

[PATCH] checkpoint: print index of new checkpoint in response message

[Patrick Palka]

This way the user can know the index of the latest checkpoint without
having to run "info checkpoints" afterwards.

2014-11-14  Patrick Palka  <patrick@parcs.ath.cx>

	* linux-fork.c (checkpoint_command): Print index of new
	checkpoint in response message.
---
 gdb/linux-fork.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gdb/linux-fork.c b/gdb/linux-fork.c
index 835e612..d7eaeb1 100644
--- a/gdb/linux-fork.c
+++ b/gdb/linux-fork.c
@@ -690,12 +690,15 @@ checkpoint_command (char *args, int from_tty)
 
   retpid = value_as_long (ret);
   get_last_target_status (&last_target_ptid, &last_target_waitstatus);
+
+  fp = find_fork_pid (retpid);
+
   if (from_tty)
     {
       int parent_pid;
 
-      printf_filtered (_("checkpoint: fork returned pid %ld.\n"),
-		       (long) retpid);
+      printf_filtered (_("checkpoint %d: fork returned pid %ld.\n"),
+		       fp != NULL ? fp->num : -1, (long) retpid);
       if (info_verbose)
 	{
 	  parent_pid = ptid_get_lwp (last_target_ptid);
@@ -706,7 +709,6 @@ checkpoint_command (char *args, int from_tty)
 	}
     }
 
-  fp = find_fork_pid (retpid);
   if (!fp)
     error (_("Failed to find new fork"));
   fork_save_infrun_state (fp, 1);
-- 
2.2.0.rc1.23.gf570943

Re: [PATCH] checkpoint: print index of new checkpoint in response message

[Patrick Palka]

On Fri, Nov 14, 2014 at 2:04 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> This way the user can know the index of the latest checkpoint without
> having to run "info checkpoints" afterwards.
>
> 2014-11-14  Patrick Palka  <patrick@parcs.ath.cx>
>
>         * linux-fork.c (checkpoint_command): Print index of new
>         checkpoint in response message.
> ---
>  gdb/linux-fork.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/gdb/linux-fork.c b/gdb/linux-fork.c
> index 835e612..d7eaeb1 100644
> --- a/gdb/linux-fork.c
> +++ b/gdb/linux-fork.c
> @@ -690,12 +690,15 @@ checkpoint_command (char *args, int from_tty)
>
>    retpid = value_as_long (ret);
>    get_last_target_status (&last_target_ptid, &last_target_waitstatus);
> +
> +  fp = find_fork_pid (retpid);
> +
>    if (from_tty)
>      {
>        int parent_pid;
>
> -      printf_filtered (_("checkpoint: fork returned pid %ld.\n"),
> -                      (long) retpid);
> +      printf_filtered (_("checkpoint %d: fork returned pid %ld.\n"),
> +                      fp != NULL ? fp->num : -1, (long) retpid);
>        if (info_verbose)
>         {
>           parent_pid = ptid_get_lwp (last_target_ptid);
> @@ -706,7 +709,6 @@ checkpoint_command (char *args, int from_tty)
>         }
>      }
>
> -  fp = find_fork_pid (retpid);
>    if (!fp)
>      error (_("Failed to find new fork"));
>    fork_save_infrun_state (fp, 1);
> --
> 2.2.0.rc1.23.gf570943
>

Ping.

Re: [PATCH] checkpoint: print index of new checkpoint in response message

[Joel Brobecker]

> This way the user can know the index of the latest checkpoint without
> having to run "info checkpoints" afterwards.
> 
> 2014-11-14  Patrick Palka  <patrick@parcs.ath.cx>
> 
> 	* linux-fork.c (checkpoint_command): Print index of new
> 	checkpoint in response message.

Looks good.

I will push this patch for you, but perhaps it might be time
for you to request "Write After Approval" privileges, allow you
to push your patches yourself. Let me know if you'd like to get
set up for that.

Thank you,
-- 
Joel

Re: [PATCH] checkpoint: print index of new checkpoint in response message

[Patrick Palka]

On Sun, Nov 23, 2014 at 4:46 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> This way the user can know the index of the latest checkpoint without
>> having to run "info checkpoints" afterwards.
>>
>> 2014-11-14  Patrick Palka  <patrick@parcs.ath.cx>
>>
>>       * linux-fork.c (checkpoint_command): Print index of new
>>       checkpoint in response message.
>
> Looks good.
>
> I will push this patch for you, but perhaps it might be time
> for you to request "Write After Approval" privileges, allow you
> to push your patches yourself. Let me know if you'd like to get
> set up for that.

Thanks for committing these patches for me.  I am interested in
write-after-approval privileges.  I will email you privately.

>
> Thank you,
> --
> Joel